Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Accessibility][High Contrast] ToolStrip grip icon colour contrast is less than 4.5:1 in Normal Mode and HC Desert mode #12663

Closed
LeafShi1 opened this issue Dec 20, 2024 · 3 comments · Fixed by #12682
Closed

[Accessibility][High Contrast] ToolStrip grip icon colour contrast is less than 4.5:1 in Normal Mode and HC Desert mode #12663

LeafShi1 opened this issue Dec 20, 2024 · 3 comments · Fixed by #12682
Assignees
@Epica3055
Labels
🚧 work in progress Work that is current in progress tenet-accessibility MAS violation, UIA issue; problems with accessibility standards
Milestone
10.0 Preview1

Comments

@LeafShi1
Copy link
Member

Minimal Reproduction Scenario

  1. Create a WinForms Project.
  2. Add a toolStrip to the project.
  3. Test the text grip icon in toolStrip by using Accessibility Insight tools.

Current Behavior

The colour contrast is less than 4.5:1 in Normal Mode and HC Desert Mode

Normal mode
Image

HC Aquatic
Image

HC Desert
Image

HC Dusk
Image

HC Night Sky
Image

Expected Behavior

The colour contrast is more than 4.5:1 in Normal Mode and all HC Mode

Test Environment

Microsoft Visual Studio Enterprise 2022 (64-bit) - main
Version 17.13.0 Preview 3.0 [35604.161.main]

Have you experienced this same issue with .NET Framework designer?

Yes

Have you experienced this same issue with previous previews of VisualStudio?

Yes, reproduce on VS 17.12

More Info

  • This issue also reproduces on MenuStrip
  • This issue also reproduces in runtime Dark Mode
    Image
@LeafShi1
Copy link
Member Author

The original issue #6208

@LeafShi1 LeafShi1 added the tenet-accessibility MAS violation, UIA issue; problems with accessibility standards label Dec 20, 2024
@Tanya-Solyanik
Copy link
Member

@Epica3055 - if this issue is easily fixable by replacing the colors, please go ahead with the fix, if not, we'll wait for a customer report.

Epica3055 added a commit to Epica3055/winforms that referenced this issue Dec 25, 2024
@Epica3055
fix dotnet#12663 [Accessibility][High Contrast] ToolStrip grip icon c…
174a974 
…olour contrast is less than 4.5:1 in Normal Mode and HC Desert mode
@Epica3055 Epica3055 mentioned this issue Dec 25, 2024
Merged
@dotnet-policy-service dotnet-policy-service bot added the 🚧 work in progress Work that is current in progress label Dec 25, 2024
ricardobossan pushed a commit to ricardobossan/winforms that referenced this issue Jan 9, 2025
@Epica3055
fix dotnet#12663 [Accessibility][High Contrast] ToolStrip grip icon c…
9024c4f 
…olour contrast is less than 4.5:1 in Normal Mode and HC Desert mode (dotnet#12682)
@Zheng-Li01
Copy link
Member

Verified the issue on latest .NET SDK 10.0.100-alpha.1.25058.38 build that the issue has been fixed as below screenshot.

Only the issue still reproduces when setting the RenderMode as "System" on Normal mode. after confirmed that the current behavior is expected due to cannot do any changes with the System mode for now.

 Win11 Results:
Image

Win10 Results:
Image

@Zheng-Li01 Zheng-Li01 added this to the 10.0 Preview1 milestone Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Epica3055 Epica3055

Labels
🚧 work in progress Work that is current in progress tenet-accessibility MAS violation, UIA issue; problems with accessibility standards
Projects
None yet
Milestone
10.0 Preview1
4 participants
@Tanya-Solyanik @Zheng-Li01 @LeafShi1 @Epica3055