Print out codesign info on failed check for equivalence #121756
Merged
+17
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elinor-fung
added
test-enhancement
Contributor
|
Tagging subscribers to this area: @vitek-karas, @agocke |
Copilot finished reviewing on behalf of
elinor-fung
November 18, 2025 22:10
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves test diagnostics by capturing and displaying codesign information when signature equivalence checks fail. When AssertMachFilesAreEquivalent throws an assertion failure, the test now outputs detailed codesign information for both the codesign-generated and managed-signed files to help debug mismatches.
Key Changes
- Added
ITestOutputHelperto the test class constructor to enable test output logging - Wrapped the equivalence assertion in a try-catch block that captures and logs verbose codesign information on failure
src/installer/tests/Microsoft.NET.HostModel.Tests/MachObjectSigning/SigningTests.cs
Show resolved
Hide resolved
src/installer/tests/Microsoft.NET.HostModel.Tests/MachObjectSigning/SigningTests.cs
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Print the output of
codesign --display --verbose=6for the two files when assert for equivalence fails.