Skip to content

System.Formats.Cbor.Tests.csproj: fails to build when bundled FSharp.Core is not on nuget CI feed. #115469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tmds opened this issue May 12, 2025 · 3 comments
Labels
area-Infrastructure-libraries untriaged New issue has not been triaged by the area owner

Comments

@tmds
Copy link
Member

tmds commented May 12, 2025

Some of our internal SDK CI builds produce an FSharp.Core version that is not available on Microsoft CI feeds.

Building runtime repository with such an SDK results in:

/home/tester/runtime/src/libraries/System.Formats.Cbor/tests/System.Formats.Cbor.Tests.csproj : error NU1603: Warning As Error: FsCheck 2.14.3 depends on FSharp.Core (>= 10.0.100-beta.25224.6) but FSharp.Core 10.0.100-beta.25224.6 was not found. FSharp.Core 10.0.100-beta.25224.102 was resolved instead. [/home/tester/runtime/Build.proj]

The issue occurs because the C# project can't find the bundled FSharp.Core package.

Like with #112729, --warnAsError false doesn't stop this warning from failing the build.

cc @ViktorHofer @omajid

@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label May 12, 2025
@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label May 12, 2025
@ViktorHofer
Copy link
Member

I think this was a point in time issue that got fixed over the weekend: dotnet/source-build#5158. Can you please try again?

Like with #112729, --warnAsError false doesn't stop this warning from failing the build.

Where do you set warnAsError? VMR or individual repo?

@tmds
Copy link
Member Author

tmds commented May 12, 2025

I think this was a point in time issue that got fixed over the weekend: dotnet/source-build#5158. Can you please try again?

I'm building 8b80947. Would that have the fix?

I also have a fix in mind and I'm about to suggest it in a PR.

Where do you set warnAsError? VMR or individual repo?

runtime build.sh.

Perhaps warnAsError false isn't applied to the test projects currently?

@vcsjones vcsjones added area-Infrastructure-libraries and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels May 12, 2025
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Infrastructure-libraries untriaged New issue has not been triaged by the area owner
Projects
None yet
3 participants