Skip to content

Commit 9ce10f1

Browse files
authored
Enable TelemetryTest (#121498)
Running in EAT mode, locally with Chrome does not reveal any problems. The failures were deterministic when disabled. Disabling happened just after emscripten bump to `3.1.12`. Now we are on `3.1.56`. Reverts: - #85678 - #109179 (added `IsBrowserAndIsBuiltWithAggressiveTrimming`) Fixes #71877, fixes #109024.
1 parent 8498fc7 commit 9ce10f1

File tree

2 files changed

+0
-3
lines changed

2 files changed

+0
-3
lines changed

src/libraries/Common/tests/TestUtilities/System/PlatformDetection.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -298,7 +298,6 @@ public static bool IsMetadataTokenSupported
298298
// Changed to `true` when trimming
299299
public static bool IsBuiltWithAggressiveTrimming => IsNativeAot || IsAppleMobile;
300300
public static bool IsNotBuiltWithAggressiveTrimming => !IsBuiltWithAggressiveTrimming;
301-
public static bool IsBrowserAndIsBuiltWithAggressiveTrimming => IsBuiltWithAggressiveTrimming && IsBrowser;
302301
public static bool IsTrimmedWithILLink => IsBuiltWithAggressiveTrimming && !IsNativeAot;
303302

304303
#if NET

src/libraries/System.Net.Http/tests/FunctionalTests/TelemetryTest.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,6 @@ public abstract class TelemetryTest : HttpClientHandlerTestBase
2222
public TelemetryTest(ITestOutputHelper output) : base(output) { }
2323

2424
[Fact]
25-
[ActiveIssue("https://github.com/dotnet/runtime/issues/71877", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))]
26-
[ActiveIssue("https://github.com/dotnet/runtime/issues/109024", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowserAndIsBuiltWithAggressiveTrimming))]
2725
public void EventSource_ExistsWithCorrectId()
2826
{
2927
Type esType = typeof(HttpClient).Assembly.GetType("System.Net.Http.HttpTelemetry", throwOnError: true, ignoreCase: false);

0 commit comments

Comments
 (0)