Skip to content

Commit 470ca86

Browse files
VSadovjkotas
andauthored
[RuntimeAsync] Remove async TODOs where issues are not blocking and tracked in some other way (#121766)
Trivial change removing some TODOs. All these TODOs are for known NYIs that are not blocking and are all tracked in some other way. Ex: Multicore JIT: #115097 R2R: #121559 PGO: #121755 --------- Co-authored-by: Jan Kotas <[email protected]>
1 parent 99aa031 commit 470ca86

File tree

3 files changed

+4
-9
lines changed

3 files changed

+4
-9
lines changed

src/coreclr/vm/class.cpp

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -660,13 +660,8 @@ HRESULT EEClass::AddMethodDesc(
660660
if (FAILED(hr = pImport->GetSigOfMethodDef(methodDef, &sigLen, &sig)))
661661
return hr;
662662

663-
SigParser sigParser(sig, sigLen);
664-
ULONG offsetOfAsyncDetails;
665-
bool isValueTask;
666-
MethodReturnKind returnKind = ClassifyMethodReturnKind(sigParser, pModule, &offsetOfAsyncDetails, &isValueTask);
667-
if (returnKind != MethodReturnKind::NormalMethod)
663+
if (IsMiAsync(dwImplFlags))
668664
{
669-
// TODO: (async) revisit and examine if this can be supported
670665
LOG((LF_ENC, LL_INFO100, "**Error** EnC for Async methods is NYI"));
671666
return E_FAIL;
672667
}

src/coreclr/vm/multicorejit.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -400,7 +400,7 @@ HRESULT MulticoreJitRecorder::WriteOutput(FILE * fp)
400400
MethodDesc * pMethod = m_JitInfoArray[i].GetMethodDescAndClean();
401401
if (pMethod->IsAsyncVariantMethod())
402402
{
403-
// TODO: (async) consider adding support for async variants in the future
403+
// TODO: (async) Multicore JIT https://github.com/dotnet/runtime/issues/115097
404404
skipped++;
405405
continue;
406406
}

src/coreclr/vm/readytoruninfo.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1120,7 +1120,7 @@ bool ReadyToRunInfo::GetPgoInstrumentationData(MethodDesc * pMD, BYTE** pAllocat
11201120
if (ReadyToRunCodeDisabled())
11211121
return false;
11221122

1123-
// TODO: (async) PGO support for async variants
1123+
// TODO: (async) PGO support for async variants (https://github.com/dotnet/runtime/issues/121755)
11241124
if (pMD->IsAsyncVariantMethod())
11251125
return false;
11261126

@@ -1196,7 +1196,7 @@ PCODE ReadyToRunInfo::GetEntryPoint(MethodDesc * pMD, PrepareCodeConfig* pConfig
11961196
if (ReadyToRunCodeDisabled())
11971197
goto done;
11981198

1199-
// TODO: (async) R2R support for async variants
1199+
// TODO: (async) R2R support for async variants (https://github.com/dotnet/runtime/issues/121559)
12001200
if (pMD->IsAsyncVariantMethod())
12011201
goto done;
12021202

0 commit comments

Comments
 (0)