Skip to content

Commit 2d8783f

Browse files
authored
Revert "Remove procdump for now" (#12431)
Reverts #12420 I don't even know if we need this, but the theory is the error was just temporary 🤷‍♂️
2 parents 1a90c55 + f30858c commit 2d8783f

File tree

2 files changed

+22
-22
lines changed

2 files changed

+22
-22
lines changed

azure-pipelines-official.yml

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -182,14 +182,14 @@ extends:
182182

183183
- template: /eng/restore-internal-tools.yml
184184

185-
# - powershell: ./eng/scripts/InstallProcDump.ps1
186-
# displayName: Install ProcDump
185+
- powershell: ./eng/scripts/InstallProcDump.ps1
186+
displayName: Install ProcDump
187187

188-
# - powershell: ./eng/scripts/StartDumpCollectionForHangingBuilds.ps1
189-
# $(ProcDumpPath)procdump.exe artifacts/log/$(_BuildConfig)
190-
# (Get-Date).AddMinutes(60)
191-
# devenv, xunit.console, xunit.console.x86
192-
# displayName: Start background dump collection
188+
- powershell: ./eng/scripts/StartDumpCollectionForHangingBuilds.ps1
189+
$(ProcDumpPath)procdump.exe artifacts/log/$(_BuildConfig)
190+
(Get-Date).AddMinutes(60)
191+
devenv, xunit.console, xunit.console.x86
192+
displayName: Start background dump collection
193193

194194
- task: NuGetAuthenticate@1
195195

@@ -241,10 +241,10 @@ extends:
241241
displayName: Run Integration Tests
242242
condition: and(eq(variables['RunIntegrationTests'], true), succeeded(), in(variables['Build.Reason'], 'PullRequest'))
243243

244-
# - powershell: ./eng/scripts/FinishDumpCollectionForHangingBuilds.ps1 artifacts/log/$(_BuildConfig)
245-
# displayName: Finish background dump collection
246-
# continueOnError: true
247-
# condition: always()
244+
- powershell: ./eng/scripts/FinishDumpCollectionForHangingBuilds.ps1 artifacts/log/$(_BuildConfig)
245+
displayName: Finish background dump collection
246+
continueOnError: true
247+
condition: always()
248248

249249
- task: 1ES.PublishPipelineArtifact@1
250250
inputs:

azure-pipelines.yml

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -104,14 +104,14 @@ stages:
104104
command: custom
105105
arguments: 'locals all -clear'
106106

107-
# - powershell: ./eng/scripts/InstallProcDump.ps1
108-
# displayName: Install ProcDump
107+
- powershell: ./eng/scripts/InstallProcDump.ps1
108+
displayName: Install ProcDump
109109

110-
# - powershell: ./eng/scripts/StartDumpCollectionForHangingBuilds.ps1
111-
# $(ProcDumpPath)procdump.exe artifacts/log/$(_BuildConfig)
112-
# (Get-Date).AddMinutes(60)
113-
# devenv, xunit.console, xunit.console.x86
114-
# displayName: Start background dump collection
110+
- powershell: ./eng/scripts/StartDumpCollectionForHangingBuilds.ps1
111+
$(ProcDumpPath)procdump.exe artifacts/log/$(_BuildConfig)
112+
(Get-Date).AddMinutes(60)
113+
devenv, xunit.console, xunit.console.x86
114+
displayName: Start background dump collection
115115

116116
# Don't create a binary log until we can customize the name
117117
# https://github.com/dotnet/arcade/pull/12988
@@ -160,10 +160,10 @@ stages:
160160
displayName: Run Integration Tests
161161
condition: and(eq(variables['RunIntegrationTests'], true), succeeded(), in(variables['Build.Reason'], 'PullRequest'))
162162

163-
# - powershell: ./eng/scripts/FinishDumpCollectionForHangingBuilds.ps1 artifacts/log/$(_BuildConfig)
164-
# displayName: Finish background dump collection
165-
# continueOnError: true
166-
# condition: always()
163+
- powershell: ./eng/scripts/FinishDumpCollectionForHangingBuilds.ps1 artifacts/log/$(_BuildConfig)
164+
displayName: Finish background dump collection
165+
continueOnError: true
166+
condition: always()
167167

168168
- publish: artifacts/log/$(_BuildConfig)
169169
artifact: $(Agent.Os)_$(Agent.JobName) Attempt $(System.JobAttempt) Logs

0 commit comments

Comments
 (0)