-
Notifications
You must be signed in to change notification settings - Fork 549
[dotnet] Set the default RuntimeIdentifier for publishing scenarios. #24329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: net11.0
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR sets default PublishRuntimeIdentifier values for iOS and tvOS platforms in publishing scenarios. The PublishRuntimeIdentifier property is used by the .NET SDK to provide a default RuntimeIdentifier when users run dotnet publish without explicitly specifying one. The defaults are set to device architectures (ios-arm64 and tvos-arm64) which align with the existing publishing logic that requires device architectures for mobile platforms.
Key Changes
- Added a new PropertyGroup to set
PublishRuntimeIdentifierdefaults for publishing scenarios - Set
ios-arm64as the default for iOS when publishing - Set
tvos-arm64as the default for tvOS when publishing
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ [CI Build #f9b7e06] Build passed (Build packages) ✅Pipeline on Agent |
✅ [PR Build #f9b7e06] Build passed (Detect API changes) ✅Pipeline on Agent |
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
✅ [CI Build #f9b7e06] Build passed (Build macOS tests) ✅Pipeline on Agent |
💻 [CI Build #f9b7e06] Tests on macOS X64 - Mac Sonoma (14) passed 💻✅ All tests on macOS X64 - Mac Sonoma (14) passed. Pipeline on Agent |
💻 [CI Build #f9b7e06] Tests on macOS M1 - Mac Monterey (12) passed 💻✅ All tests on macOS M1 - Mac Monterey (12) passed. Pipeline on Agent |
💻 [CI Build #f9b7e06] Tests on macOS arm64 - Mac Sequoia (15) passed 💻✅ All tests on macOS arm64 - Mac Sequoia (15) passed. Pipeline on Agent |
💻 [CI Build #f9b7e06] Tests on macOS M1 - Mac Ventura (13) passed 💻✅ All tests on macOS M1 - Mac Ventura (13) passed. Pipeline on Agent |
💻 [CI Build #f9b7e06] Tests on macOS arm64 - Mac Tahoe (26) passed 💻✅ All tests on macOS arm64 - Mac Tahoe (26) passed. Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
🔥 [CI Build #f9b7e06] Test results 🔥Test results❌ Tests failed on VSTS: test results 0 tests crashed, 2 tests failed, 129 tests passed. Failures❌ monotouch tests (iOS) [attempt 2]
Html Report (VSDrops) Download ❌ monotouch tests (tvOS) [attempt 2]
Html Report (VSDrops) Download Successes✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
PENDING: tests
Ref: dotnet/sdk#27253