-
Notifications
You must be signed in to change notification settings - Fork 790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cancellable: add safer APIs to check the token #18175
base: main
Are you sure you want to change the base?
Conversation
❗ Release notes required
|
8bc52c7
to
cccc177
Compare
There's a failing test in the macOS run:
It doesn't seem related to the changes in this PR. |
Yes, unrelated: #18115 |
Another unrelated failure:
|
Failed to run : https://github.com/dotnet/fsharp/actions/runs/12481264245 |
It's green now 🙂 |
There're cases where reading an assembly metadata may happen outside of the type checking routine. For example, computing code completion suggestions or Parameter Info signature may trigger reading of types that haven't been imported during the checking. We want to be able to check if the metadata reading is happening inside a
Cancellable
context and to check for interruptions in a safer way.