Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GraphNode deadlock #18178

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix GraphNode deadlock #18178

wants to merge 1 commit into from

Conversation

majocha
Copy link
Contributor

@majocha majocha commented Dec 28, 2024

Description

Fix the deadlock by replacing the continuation with a simple await. Also simplify the code a bit.

Fixes #18115

Checklist

  • Tested by running 1000 iterations locally but it should be apparent in the CI if the fix really works.
  • Performance should be unchanged or a bit better because of less indirect code.
  • Release notes entry updated

@majocha majocha requested a review from a team as a code owner December 28, 2024 10:26
@github-actions GitHub Actions
Copy link
Contributor

❗ Release notes required

@majocha,

Caution

No release notes found for the changed paths (see table below).

Please make sure to add an entry with an informative description of the change as well as link to this pull request, issue and language suggestion if applicable. Release notes for this repository are based on Keep A Changelog format.

The following format is recommended for this repository:

* <Informative description>. ([PR #XXXXX](https://github.com/dotnet/fsharp/pull/XXXXX))

See examples in the files, listed in the table below or in th full documentation at https://fsharp.github.io/fsharp-compiler-docs/release-notes/About.html.

If you believe that release notes are not necessary for this PR, please add NO_RELEASE_NOTES label to the pull request.

You can open this PR in browser to add release notes: open in github.dev

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/9.0.200.md No release notes found or release notes format is not correct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0101 0101 0101 approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
F# Compiler and Tooling
Status: New
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rare deadlock in GraphNode.GetOrComputeValue
2 participants
@majocha @0101