Per our conventions, this parameter shouldn't have "is" prefix. (#35957)

Author: cincuranet

src/EFCore.Cosmos/Query/Internal/CosmosShapedQueryCompilingExpressionVisitor.ParameterInliner.cs

@@ -116,7 +116,7 @@ protected override Expression VisitExtension(Expression expression)
 
                     return new SqlFunctionExpression(
                         fullTextScoreFunction.Name,
-                        isScoringFunction: true,
+                        scoringFunction: true,
                         [property, sqlExpressionFactory.Constant(keywordValues, typeMapping)],
                         fullTextScoreFunction.Type,
                         fullTextScoreFunction.TypeMapping);

src/EFCore.Cosmos/Query/Internal/Expressions/SqlFunctionExpression.cs

@@ -26,7 +26,7 @@ public SqlFunctionExpression(
         IEnumerable<Expression> arguments,
         Type type,
         CoreTypeMapping? typeMapping)
-        : this(name, isScoringFunction: false, arguments, type, typeMapping)
+        : this(name, scoringFunction: false, arguments, type, typeMapping)
     {
     }
 
@@ -38,15 +38,15 @@ public SqlFunctionExpression(
     /// </summary>
     public SqlFunctionExpression(
         string name,
-        bool isScoringFunction,
+        bool scoringFunction,
         IEnumerable<Expression> arguments,
         Type type,
         CoreTypeMapping? typeMapping)
         : base(type, typeMapping)
     {
         Name = name;
         Arguments = arguments.ToList();
-        IsScoringFunction = isScoringFunction;
+        IsScoringFunction = scoringFunction;
     }
 
     /// <summary>

src/EFCore.Cosmos/Query/Internal/SqlExpressionFactory.cs

@@ -660,7 +660,7 @@ public virtual SqlExpression Function(
         IEnumerable<Expression> arguments,
         Type returnType,
         CoreTypeMapping? typeMapping = null)
-        => BuildFunction(functionName, isScoringFunction: false, arguments, returnType, typeMapping);
+        => BuildFunction(functionName, scoringFunction: false, arguments, returnType, typeMapping);
 
     /// <summary>
     ///     This is an internal API that supports the Entity Framework Core infrastructure and not subject to
@@ -673,11 +673,11 @@ public virtual SqlExpression ScoringFunction(
         IEnumerable<Expression> arguments,
         Type returnType,
         CoreTypeMapping? typeMapping = null)
-        => BuildFunction(functionName, isScoringFunction: true, arguments, returnType, typeMapping);
+        => BuildFunction(functionName, scoringFunction: true, arguments, returnType, typeMapping);
 
     private SqlExpression BuildFunction(
         string functionName,
-        bool isScoringFunction,
+        bool scoringFunction,
         IEnumerable<Expression> arguments,
         Type returnType,
         CoreTypeMapping? typeMapping = null)
@@ -691,7 +691,7 @@ private SqlExpression BuildFunction(
 
         return new SqlFunctionExpression(
             functionName,
-            isScoringFunction,
+            scoringFunction,
             typeMappedArguments,
             returnType,
             typeMapping);