Skip to content

Commit f46a5cf

Browse files
authoredOct 2, 2024··
Centralize TFM infrastructure (#4971)
1 parent cde505c commit f46a5cf

File tree

56 files changed

+90
-80
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

56 files changed

+90
-80
lines changed
 

‎Directory.Build.props

+15-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
1111
<SuppressNETCoreSdkPreviewMessage>true</SuppressNETCoreSdkPreviewMessage>
1212
<_SkipUpgradeNetAnalyzersNuGetWarning>true</_SkipUpgradeNetAnalyzersNuGetWarning>
13-
</PropertyGroup>
13+
</PropertyGroup>
1414

1515
<PropertyGroup>
1616
<PackageIconUrl>http://go.microsoft.com/fwlink/?LinkID=288859</PackageIconUrl>
@@ -19,4 +19,18 @@
1919
<EnableSourceControlManagerQueries>true</EnableSourceControlManagerQueries>
2020
<GitHubRepositoryName>diagnostics</GitHubRepositoryName>
2121
</PropertyGroup>
22+
23+
<PropertyGroup>
24+
<!-- This represents the minimum supported .NET Version, so the min
25+
version that the tools must be able to run against for a simple customer
26+
experience.
27+
When bumping this, bump __targetRid in build.sh/build-native.cmd
28+
and modify the Debugger.Tests.Configs to reflect the new TFMs -->
29+
<NetCoreAppMinVersion>6.0</NetCoreAppMinVersion>
30+
<NetCoreAppMinTargetFramework>net$(NetCoreAppMinVersion)</NetCoreAppMinTargetFramework>
31+
<!-- this is the list of TFMs we build our debuggees and tracees as. -->
32+
<SupportedSubProcessTargetFrameworks>net6.0;net7.0;net8.0;net9.0</SupportedSubProcessTargetFrameworks>
33+
<!-- this is the list of TFMs we build our unit tests as. -->
34+
<SupportedXUnitTestTargetFrameworks>net6.0;net7.0;net8.0</SupportedXUnitTestTargetFrameworks>
35+
</PropertyGroup>
2236
</Project>

‎documentation/privatebuildtesting.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ Here are some instructions on how to run the diagnostics repo's tests against a
99
4. On Windows 11 (this doesn't work on Windows 10), add the following DWORD registry key: `HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows NT\CurrentVersion\MiniDumpSettings\DisableAuxProviderSignatureCheck` and set it to 1. This allows the unsigned privately built DAC to be used to generate dumps.
1010
5. Copy the private runtime binaries over the test SDK/runtimes installed in `.dotnet-test`. This step is hard to automate because there are usually 3 versions of the runtime installed: one as part of the .NET SDK, one as part of the AspNetCore runtime and one from latest runtime DARC update.
1111
6. Run the diagnostics repo tests either:
12-
a. `test.cmd` or `test.sh` - this runs all the diagnostics tests including SOS's. A html test report will be generated in `artifacts/TestResults/{Debug,Release}/SOS.UnitTests_net6.0_x64.html`.
12+
a. `test.cmd` or `test.sh` - this runs all the diagnostics tests including SOS's. A html test report will be generated in `artifacts/TestResults/{Debug,Release}/SOS.UnitTests_net8.0_x64.html`.
1313
b. Use the VS Test Explorer to run all the SOS tests or a specific one.
1414
c. Use `eng\testsos.cmd` or `eng/testsos.sh` to run just the SOS tests. The html test report isn't generated in this case, but the SOS test logs are in artifacts/TestResults/{Debug,Release}/sos_*.
1515

0 commit comments

Comments
 (0)
Please sign in to comment.