Skip to content

Remove Newtonsoft.Json dependency from JsonPatch #52366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task done
EasyLOB opened this issue Nov 25, 2023 · 4 comments
Closed
1 task done

Remove Newtonsoft.Json dependency from JsonPatch #52366

EasyLOB opened this issue Nov 25, 2023 · 4 comments
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates ✔️ Resolution: Duplicate Resolved as a duplicate of another issue Status: Resolved

Comments

@EasyLOB
Copy link

EasyLOB commented Nov 25, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Is your feature request related to a problem? Please describe the problem.

I just moved to .NET 8.0, removed Newtonsoft.Json dependency and moved to System.Text.Json.
BUT, when I create an API PATCH method with JsonPatch ( refer to link below ) I have to install Microsoft.AspNetCore.Mvc.NewtonsoftJson:

https://learn.microsoft.com/en-us/aspnet/core/web-api/jsonpatch?view=aspnetcore-8.0

Describe the solution you'd like

Any plans to remove Newtonsoft.Json dependency from JsonPatch and adopt System.Text.Json?

Additional context

No response

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Nov 25, 2023
@davidfowl
Copy link
Member

davidfowl commented Nov 25, 2023

Dupe of #24333

https://github.com/Havunen/SystemTextJsonPatch

@davidfowl davidfowl reopened this Nov 25, 2023
@dotnet-policy-service dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Feb 6, 2024
@wtgodbe wtgodbe removed the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Feb 6, 2024
@dotnet-policy-service dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Feb 6, 2024
@wtgodbe wtgodbe removed the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Feb 13, 2024
@dotnet dotnet deleted a comment from dotnet-policy-service bot Feb 13, 2024
@dotnet dotnet deleted a comment from dotnet-policy-service bot Feb 13, 2024
@mkArtakMSFT
Copy link
Member

@davidfowl what was the reason for reopening this issue rather than keeping it closed as a dupe of #24333?

@stevendarby, @chenzuo I see you guys have not liked the previous comment about closing this as a dupe. What was the reason? Because removing Newtonsoft.Json dependency will be in favor of the framework-provided System.Text.Json instead, which is exactly what the other issue is tracking.

@stevendarby
Copy link

@mkArtakMSFT I wasn't pleased that MS are recommending other libraries instead of updating their own (see also my post on the linked issue.)

@davidfowl
Copy link
Member

@mkArtakMSFT I think reopend it because it was closed as completed. We can close this as a dupe now

@mkArtakMSFT mkArtakMSFT added the ✔️ Resolution: Duplicate Resolved as a duplicate of another issue label Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates ✔️ Resolution: Duplicate Resolved as a duplicate of another issue Status: Resolved
Projects
None yet
Development

No branches or pull requests

5 participants