Skip to content

Commit 35554db

Browse files
committed
fix(SignalR): ensure access token factory is always called and improve error handling in tests
1 parent 372a70a commit 35554db

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

src/SignalR/clients/ts/signalr/src/AccessTokenHttpClient.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ export class AccessTokenHttpClient extends HttpClient {
6565
}
6666

6767
private async _refreshTokenAndRetry(request: HttpRequest, original: HttpResponse | Error): Promise<HttpResponse> {
68-
const newToken = await this._accessTokenFactory();
68+
const newToken = await this._accessTokenFactory!();
6969
if (!newToken) {
7070
if (original instanceof HttpResponse) {
7171
return original;

src/SignalR/clients/ts/signalr/tests/AccessTokenHttpClient.test.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -72,8 +72,7 @@ describe("AccessTokenHttpClient", () => {
7272

7373
await client.get("http://example.com/prime");
7474
try {
75-
await client.get("http://example.com/resource");
76-
expect.fail("expected to throw");
75+
await expect(client.get("http://example.com/resource")).rejects.toThrow(HttpError);
7776
} catch (e: any) {
7877
expect(e).toBeInstanceOf(HttpError);
7978
expect(e.statusCode ?? e.status).toBe(status);

0 commit comments

Comments
 (0)