Change return type from MqttPublishPacket to MqttPacketWithIdentifier

Author: Anton Smolkov

Source/MQTTnet.Server/Status/MqttSessionStatus.cs

@@ -48,7 +48,7 @@ public Task DeleteAsync()
     /// <returns>
     /// A task that represents the asynchronous operation. The result contains the delivered MQTT publish packet.
     /// </returns>
-    public async Task<MqttPublishPacket> DeliverApplicationMessageAsync(MqttApplicationMessage applicationMessage)
+    public async Task<MqttPacketWithIdentifier> DeliverApplicationMessageAsync(MqttApplicationMessage applicationMessage)
     {
         ArgumentNullException.ThrowIfNull(applicationMessage);
 
@@ -57,7 +57,7 @@ public async Task<MqttPublishPacket> DeliverApplicationMessageAsync(MqttApplicat
 
         var mqttPacket = await packetBusItem.WaitAsync();
 
-        return (MqttPublishPacket)mqttPacket;
+        return (MqttPacketWithIdentifier)mqttPacket;
     }
 
     /// <summary>
@@ -72,7 +72,7 @@ public async Task<MqttPublishPacket> DeliverApplicationMessageAsync(MqttApplicat
     /// However, an existing message in the queue may be <b>dropped later</b> to make room for the newly enqueued message.
     /// Such dropped messages can be tracked by subscribing to <see cref="MqttServer.QueuedApplicationMessageOverwrittenAsync"/> event.
     /// </remarks>
-    public bool TryEnqueueApplicationMessage(MqttApplicationMessage applicationMessage, out MqttPublishPacket publishPacket)
+    public bool TryEnqueueApplicationMessage(MqttApplicationMessage applicationMessage, out MqttPacketWithIdentifier publishPacket)
     {
         ArgumentNullException.ThrowIfNull(applicationMessage);
 

Source/MQTTnet.Tests/Server/Injection_Tests.cs

@@ -3,6 +3,7 @@
 using Microsoft.VisualStudio.TestTools.UnitTesting;
 using MQTTnet.Internal;
 using MQTTnet.Packets;
+using MQTTnet.Protocol;
 using MQTTnet.Server;
 using MQTTnet.Server.Exceptions;
 
@@ -28,7 +29,10 @@ public async Task Enqueue_Application_Message_At_Session_Level()
             await receiver1.SubscribeAsync("#");
             await receiver2.SubscribeAsync("#");
 
-            var message = new MqttApplicationMessageBuilder().WithTopic("InjectedOne").Build();
+            var message = new MqttApplicationMessageBuilder()
+                .WithQualityOfServiceLevel(MqttQualityOfServiceLevel.AtLeastOnce)
+                .WithTopic("InjectedOne").Build();
+
             var enqueued = clientStatus.TryEnqueueApplicationMessage(message, out var publishPacket);
 
             Assert.IsTrue(enqueued);
@@ -215,7 +219,10 @@ public async Task Deliver_Application_Message_At_Session_Level()
             await receiver1.SubscribeAsync("#");
             await receiver2.SubscribeAsync("#");
 
-            var mqttApplicationMessage = new MqttApplicationMessageBuilder().WithTopic("InjectedOne").Build();
+            var mqttApplicationMessage = new MqttApplicationMessageBuilder()
+                .WithTopic("InjectedOne")
+                .WithQualityOfServiceLevel(MqttQualityOfServiceLevel.AtLeastOnce)
+                .Build();
             var publishPacket = await clientStatus.DeliverApplicationMessageAsync(mqttApplicationMessage);
 
             await LongTestDelay();