Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding PrepareForBuildDependsOn section as instructed disables PreComputeCompileTypeScriptWithTSConfig task #34415

Open
JeroMiya opened this issue Dec 26, 2024 · 1 comment
Labels
aspnet-core/svc razor-pages/subsvc Source - Docs.ms Docs Customer feedback via GitHub Issue waiting-on-feedback Waiting for feedback from SMEs

Comments

@JeroMiya
Copy link

JeroMiya commented Dec 26, 2024

Description

The documentation suggests adding a <PrepareForBuildDependsOn>...</PrepareForBuildDependsOn> section to integrate TypeScript compilation into the project, however doing so will cause the PreComputeCompileTypeScriptWithTSConfig task to be skipped, possibly because the tsconfig.json file is not yet available in the content file list at that stage in the build? The end result is that tsconfig.json cannot be used when the PrepareForBuildDependsOn element is added as instructed in the documentation.

This is potentially additionally a more critical issue in the .net 9 SDK, as it appears the build will error at the static file fingerprinting stage if the PrepareForBuildDependsOn element is NOT added.

Page URL

https://learn.microsoft.com/en-us/aspnet/core/razor-pages/ui-class?view=aspnetcore-8.0&tabs=visual-studio#typescript-integration

Content source URL

https://github.com/dotnet/AspNetCore.Docs/blob/main/aspnetcore/razor-pages/ui-class.md

Document ID

fd116d00-0dc7-efaf-c714-34d77b345a05

Article author

@tdykstra

Related Issues

@tdykstra
Copy link
Contributor

@javiercn what should the documentation say here? Should we transfer this issue to the aspnetcore repo? 
cc: @BrennanConroy

@tdykstra tdykstra added waiting-on-feedback Waiting for feedback from SMEs and removed ⌚ Not Triaged labels Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aspnet-core/svc razor-pages/subsvc Source - Docs.ms Docs Customer feedback via GitHub Issue waiting-on-feedback Waiting for feedback from SMEs
Projects
None yet
Development

No branches or pull requests

2 participants