Fixed an issue with selectionLimit 1 and idProp closes #33

pkempenaers · pkempenaers · commit b551913d4af0 · 2016-11-24T09:41:23.000+01:00
diff --git a/src/angularjs-dropdown-multiselect.js b/src/angularjs-dropdown-multiselect.js
@@ -288,7 +288,7 @@ directiveModule.directive('ngDropdownMultiselect', ['$filter', '$document', '$co
 					return object[property];
 				}
 
-				return '';
+				return undefined;
 			};
 
 			$scope.selectAll = function() {
@@ -367,7 +367,7 @@ directiveModule.directive('ngDropdownMultiselect', ['$filter', '$document', '$co
 
 			$scope.isChecked = function(id) {
 				if ($scope.singleSelection) {
-					return $scope.selectedModel !== null && angular.isDefined($scope.selectedModel[$scope.settings.idProp]) && $scope.selectedModel[$scope.settings.idProp] === getFindObj(id)[$scope.settings.idProp];
+					return $scope.selectedModel !== null && angular.isDefined($scope.selectedModel[$scope.settings.externalIdProp]) && $scope.selectedModel[$scope.settings.externalIdProp] === getFindObj(id)[$scope.settings.externalIdProp];
 				}
 
 				return findIndex($scope.selectedModel, getFindObj(id)) !== -1;

Original file line number	Diff line number	Diff line change
`@@ -288,7 +288,7 @@ directiveModule.directive('ngDropdownMultiselect', ['$filter', '$document', '$co`
`288`	`288`	`return object[property];`
`289`	`289`	`}`
`290`	`290`
`291`		`- return '';`
	`291`	`+ return undefined;`
`292`	`292`	`};`
`293`	`293`
`294`	`294`	`$scope.selectAll = function() {`
`@@ -367,7 +367,7 @@ directiveModule.directive('ngDropdownMultiselect', ['$filter', '$document', '$co`
`367`	`367`
`368`	`368`	`$scope.isChecked = function(id) {`
`369`	`369`	`if ($scope.singleSelection) {`
`370`		`- return $scope.selectedModel !== null && angular.isDefined($scope.selectedModel[$scope.settings.idProp]) && $scope.selectedModel[$scope.settings.idProp] === getFindObj(id)[$scope.settings.idProp];`
	`370`	`+ return $scope.selectedModel !== null && angular.isDefined($scope.selectedModel[$scope.settings.externalIdProp]) && $scope.selectedModel[$scope.settings.externalIdProp] === getFindObj(id)[$scope.settings.externalIdProp];`
`371`	`371`	`}`
`372`	`372`
`373`	`373`	`return findIndex($scope.selectedModel, getFindObj(id)) !== -1;`