From 3f9e5444d07622492f79ce8940b95e99664c9604 Mon Sep 17 00:00:00 2001 From: 8ctopus Date: Mon, 25 Nov 2024 17:04:51 +0400 Subject: [PATCH 1/2] Fix php 8.4 deprecation nullable parameter must be explicitly declared --- src/FontLib/TrueType/File.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/FontLib/TrueType/File.php b/src/FontLib/TrueType/File.php index ee3c84e..f4c797a 100644 --- a/src/FontLib/TrueType/File.php +++ b/src/FontLib/TrueType/File.php @@ -100,7 +100,7 @@ class File extends BinaryStream { "Ccaron", "ccaron", "dmacron" ); - private function uniord (string $c, string $encoding = null) { + private function uniord (string $c, ?string $encoding = null) { if (function_exists("mb_ord")) { if (PHP_VERSION_ID < 80000 && $encoding === null) { // in PHP < 8 the encoding argument, if supplied, must be a valid encoding From aca1b193f452bc62b29382f4c728485528f5419b Mon Sep 17 00:00:00 2001 From: 8ctopus Date: Mon, 25 Nov 2024 20:24:29 +0400 Subject: [PATCH 2/2] Add php 8.4 to github action workflow --- .github/workflows/phpunit.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/phpunit.yml b/.github/workflows/phpunit.yml index 8be9545..96b6dc0 100644 --- a/.github/workflows/phpunit.yml +++ b/.github/workflows/phpunit.yml @@ -23,6 +23,7 @@ jobs: - "8.1" - "8.2" - "8.3" + - "8.4" steps: