Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undefined outline causes font parsing failure #104

Closed
bsweeney opened this issue Dec 17, 2021 · 1 comment · Fixed by #128
Closed

Undefined outline causes font parsing failure #104

bsweeney opened this issue Dec 17, 2021 · 1 comment · Fixed by #128
Milestone
0.5.5

Comments

@bsweeney
Copy link
Member

bsweeney commented Dec 17, 2021 •
edited
Loading

If an outline is created without a non-positive size the raw value is unset. This causes an error in PHP 8.1 when trying to subset the font since there is no outline to encode.

Deprecated: mb_strlen(): Passing null to parameter 1 ($string) of type string is deprecated in php-font-lib/src/FontLib/Glyph/Outline.php on line 99
@bsweeney bsweeney added this to the 0.5.4 milestone Dec 17, 2021
bsweeney added a commit that referenced this issue Dec 17, 2021
@bsweeney
Read outlines even if the size is not set
c4946e7 
This populates the raw outline data, which prevents errors during font parsing.

partially addresses #104
@bsweeney
Copy link
Member Author

While the actual error is addressed in 0.5.4 this issue is likely caused by some incorrect logic elsewhere and the issue could use further investigation.

bsweeney added a commit that referenced this issue Dec 17, 2021
@bsweeney
Read outlines even if the size is not set
dd448ad 
This populates the raw outline data, which prevents errors during font parsing.

partially addresses #104
@bsweeney bsweeney linked a pull request Oct 21, 2023 that will close this issue
Address errors caused by attempting to read data when none exists #128
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.5.5
Development

Successfully merging a pull request may close this issue.

Address errors caused by attempting to read data when none exists dompdf/php-font-lib
1 participant
@bsweeney