Changed base type of Dictable to be Iterable and not ABC, to indicate to mypy that __iter__ is implemented

Author: domdfcoding

domdf_python_tools/bases.py

@@ -25,7 +25,7 @@
 #
 
 # stdlib
-from abc import ABC, abstractmethod
+from abc import abstractmethod
 from collections import UserList
 from pprint import pformat
 from typing import Any, Callable, Dict, Iterable, Tuple
@@ -34,7 +34,7 @@
 import pydash  # type: ignore
 
 
-class Dictable(ABC):
+class Dictable(Iterable):
 	"""
 	The basic structure of a class that can be converted into a dictionary
 	"""
@@ -46,7 +46,7 @@ def __init__(self, *args, **kwargs):
 	def __str__(self) -> str:
 		return self.__repr__()
 
-	def __iter__(self) -> Iterable[Tuple[str, Any]]:
+	def __iter__(self) -> Iterable[Tuple[str, Any]]:  # type: ignore[override]
 		for key, value in self.__dict__.items():
 			yield key, value
 

tests/mypy_test.py

@@ -0,0 +1,28 @@
+# stdlib
+from typing import Any, Dict
+
+# this package
+from domdf_python_tools.bases import Dictable
+
+
+class MyDictable(Dictable):
+	def __init__(self, foo: str, bar: int):
+		super().__init__()
+
+		self.foo: str = foo
+		self.bar: float = float(bar)
+
+	@property
+	def __dict__(self):
+		return dict(
+				foo=self.foo,
+				bar=self.bar
+				)
+
+
+def myfunc() -> Dict[str, Any]:
+	a = MyDictable("foo", 12)
+	return dict(a)
+
+
+myfunc()