Force ban pagination

Author: dolfies

discord/guild.py

@@ -2835,15 +2835,19 @@ async def bans(
         limit: Optional[int] = 1000,
         before: Snowflake = MISSING,
         after: Snowflake = MISSING,
-        paginate: bool = True,
     ) -> AsyncIterator[BanEntry]:
         """Retrieves an :term:`asynchronous iterator` of the users that are banned from the guild as a :class:`BanEntry`.
 
         You must have :attr:`~Permissions.ban_members` to get this information.
 
         .. versionchanged:: 2.0
+
             Due to a breaking change in Discord's API, this now returns a paginated iterator instead of a list.
 
+        .. versionchanged:: 2.1
+
+            Removed the ``paginate`` parameter. It is now always paginated.
+
         Examples
         ---------
 
@@ -2869,11 +2873,6 @@ async def bans(
             Retrieves bans before this user.
         after: :class:`.abc.Snowflake`
             Retrieve bans after this user.
-        paginate: :class:`bool`
-            Whether to paginate the results. If ``False``, all bans are fetched with a single request and yielded,
-            ``limit`` is ignored, and ``before`` and ``after`` must not be provided.
-
-            .. versionadded:: 2.0
 
         Raises
         -------
@@ -2897,15 +2896,6 @@ async def bans(
         _state = self._state
         endpoint = _state.http.get_bans
 
-        if not paginate:
-            # For user accounts, not providing a limit will return *every* ban,
-            # as they were too lazy to implement proper pagination in the client
-            # However, pagination may be wanted for guilds with massive ban lists
-            data = await endpoint(self.id)
-            for entry in data:
-                yield BanEntry(user=User(state=_state, data=entry['user']), reason=entry['reason'])
-            return
-
         async def _before_strategy(retrieve: int, before: Optional[Snowflake], limit: Optional[int]):
             before_id = before.id if before else None
             data = await endpoint(self.id, limit=retrieve, before=before_id)

discord/http.py

@@ -2148,7 +2148,7 @@ def create_from_template(self, code: str, name: str, icon: Optional[str]) -> Res
     def get_bans(
         self,
         guild_id: Snowflake,
-        limit: Optional[int] = None,
+        limit: int = 1000,
         before: Optional[Snowflake] = None,
         after: Optional[Snowflake] = None,
     ) -> Response[List[guild.Ban]]: