Standardize usage of final classes, private constructors, @SuppressWarnings, and @ApiStatus

[Trikzon]

After the cosmetics pr is complete, we should standardize the uses of these language features.

Final Classes

I'm for removing all our final class uses. It's pointless to use imo.

Private constructors

I think that all of our static-only method classes should have a private no argument constructor.

@SuppressWarnings

I usually don't ever use these, so I'd like feedback on how we should standardize its usage. Right now it feels like @andantedevs is adding them kinda at random rather than every time they could be used.

@ApiStatus

I think we should take full use of this annotation. I think it might break compatibility with non-jetbrains editors, but I'm not too worried for that tbh

[dvitski]

@SuppressWarnings

Having worked by myself for a while, my usage of this is kind of instinctive, but the basis is 'if it's creating an unnecessary warning, add a suppression'

• if it's a block/item etc that's made to be used by other mods, @SuppressWarnings("unused")
• if there's a deprecation, and it's one of Mojang's weird formatting deprecations or quite frankly anywhere actually, ew, get it out of here, @SuppressWarnings("deprecation")
• if there's some mixin-based confusion with an editor, like casting, suppress the warning
• or essentially anything that's giving you unnecessary warnings that you don't want to disable inspections for completely

[Trikzon]

Do you generally look at warnings when writing code? I've grown to just institutionally ignore them, but I do get where you're coming from

[dvitski]

I'm one for a clean warnings gutter lmao