Added missing proxy fields #22
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using http.get() to request a file through a proxy, the following were missing from the previous implementation: * The `http://` protocol * The `headers` object indicating the target `Host` These additions are based on http://stackoverflow.com/a/6781592/1228454 and work for our company proxy (MS NTLM Proxy).
|
Worked for me too 👍 |
|
@dodo this would then resolve many issues on dependant projects: the symptom I'm seeing is ...The proxy server sends back a page saying "Sorry, I don't know how to get to that URL without a protocol" and this library tries to parse the error page as if it was |
This was referenced Aug 26, 2016
|
Does this needs any more work before merging? |
|
This would also fix an issue I'm seeing on Circle CI: 😄 |
|
Hi there, any news on this? This issue is pretty annoying... :) |
|
+1 on this, it is a very annoying issue causing our travis-ci builds to fail. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using http.get() to request a file through a proxy, the following were missing from the previous implementation:
http://protocolheadersobject indicating the targetHostThese additions are based on http://stackoverflow.com/a/6781592/1228454 and work for our company proxy (MS NTLM Proxy).
The previous implementation always silently failed, it simply exited the process right after the
fetching ...message.