configure: validate exactly one model argument before -- separator

Signed-off-by: Dorin Geman <[email protected]>

Author: doringeman

commands/configure.go

@@ -14,11 +14,23 @@ func newConfigureCmd() *cobra.Command {
 		Use:   "configure [--context-size=<n>] MODEL [-- <runtime-flags...>]",
 		Short: "Configure runtime options for a model",
 		Args: func(cmd *cobra.Command, args []string) error {
-			if len(args) < 1 {
-				return fmt.Errorf(
-					"Model specification is required.\n\n" +
-						"See 'docker model configure --help' for more information",
-				)
+			argsBeforeDash := cmd.ArgsLenAtDash()
+			if argsBeforeDash == -1 {
+				// No "--" used, so we need exactly 1 total argument.
+				if len(args) != 1 {
+					return fmt.Errorf(
+						"Exactly one model must be specified, got %d: %v\n\n"+
+							"See 'docker model configure --help' for more information",
+						len(args), args)
+				}
+			} else {
+				// Has "--", so we need exactly 1 argument before it.
+				if argsBeforeDash != 1 {
+					return fmt.Errorf(
+						"Exactly one model must be specified before --, got %d\n\n"+
+							"See 'docker model configure --help' for more information",
+						argsBeforeDash)
+				}
 			}
 			opts.Model = args[0]
 			opts.RuntimeFlags = args[1:]