fix(desktop/chat): remove unused parameter

Signed-off-by: Dorin Geman <[email protected]>

Author: doringeman

commands/run.go

@@ -269,15 +269,15 @@ func chatWithMarkdown(cmd *cobra.Command, client *desktop.Client, backend, model
 
 	if !useMarkdown {
 		// Simple case: just stream as plain text
-		return client.ChatStreaming(backend, model, prompt, apiKey, func(content string) {
+		return client.Chat(backend, model, prompt, apiKey, func(content string) {
 			cmd.Print(content)
-		}, false)
+		})
 	}
 
 	// For markdown: use streaming buffer to render code blocks as they complete
 	markdownBuffer := NewStreamingMarkdownBuffer()
 
-	err := client.ChatStreaming(backend, model, prompt, apiKey, func(content string) {
+	err := client.Chat(backend, model, prompt, apiKey, func(content string) {
 		// Use the streaming markdown buffer to intelligently render content
 		rendered, err := markdownBuffer.AddContent(content, true)
 		if err != nil {
@@ -289,8 +289,7 @@ func chatWithMarkdown(cmd *cobra.Command, client *desktop.Client, backend, model
 		} else if rendered != "" {
 			cmd.Print(rendered)
 		}
-	}, false)
-
+	})
 	if err != nil {
 		return err
 	}

desktop/desktop.go

@@ -365,7 +365,7 @@ func (c *Client) fullModelID(id string) (string, error) {
 }
 
 // Chat performs a chat request and streams the response content with selective markdown rendering.
-func (c *Client) ChatStreaming(backend, model, prompt, apiKey string, outputFunc func(string), shouldUseMarkdown bool) error {
+func (c *Client) Chat(backend, model, prompt, apiKey string, outputFunc func(string)) error {
 	model = normalizeHuggingFaceModelName(model)
 	if !strings.Contains(strings.Trim(model, "/"), "/") {
 		// Do an extra API call to check if the model parameter isn't a model ID.
@@ -452,10 +452,19 @@ func (c *Client) ChatStreaming(backend, model, prompt, apiKey string, outputFunc
 					outputFunc("\n\n")
 				}
 				if printerState != chatPrinterReasoning {
-					reasoningFmt.Println("Thinking:")
+					const thinkingHeader = "Thinking:\n"
+					if reasoningFmt != nil {
+						outputFunc(reasoningFmt.Sprint(thinkingHeader))
+					} else {
+						outputFunc(thinkingHeader)
+					}
 				}
 				printerState = chatPrinterReasoning
-				reasoningFmt.Print(chunk)
+				if reasoningFmt != nil {
+					outputFunc(reasoningFmt.Sprint(chunk))
+				} else {
+					outputFunc(chunk)
+				}
 			}
 			if streamResp.Choices[0].Delta.Content != "" {
 				chunk := streamResp.Choices[0].Delta.Content
@@ -475,15 +484,6 @@ func (c *Client) ChatStreaming(backend, model, prompt, apiKey string, outputFunc
 	return nil
 }
 
-// Chat performs a chat request and returns the response content (backwards compatibility).
-func (c *Client) Chat(backend, model, prompt, apiKey string) (string, error) {
-	var result strings.Builder
-	err := c.ChatStreaming(backend, model, prompt, apiKey, func(content string) {
-		result.WriteString(content)
-	}, false) // Use false to maintain backwards compatibility
-	return result.String(), err
-}
-
 func (c *Client) Remove(models []string, force bool) (string, error) {
 	modelRemoved := ""
 	for _, model := range models {

desktop/desktop_test.go

@@ -63,7 +63,7 @@ func TestChatHuggingFaceModel(t *testing.T) {
 		Body:       io.NopCloser(bytes.NewBufferString("data: {\"choices\":[{\"delta\":{\"content\":\"Hello there!\"}}]}\n")),
 	}, nil)
 
-	_, err := client.Chat("", modelName, prompt, "")
+	err := client.Chat("", modelName, prompt, "", func(s string) {})
 	assert.NoError(t, err)
 }