[25.0 backport] Add tests for CLI/plugin communication #4856
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Laura Brehm <laurabrehm@hey.com> (cherry picked from commit 469bfc0) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Laura Brehm <laurabrehm@hey.com> (cherry picked from commit 1c4d6d8) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Adds a new plugin to the e2e plugins that simulates an older plugin binary and a test suite to ensure older plugin binaries keep behaving the same with newer CLI versions. Signed-off-by: Laura Brehm <laurabrehm@hey.com> (cherry picked from commit cfa9fef) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
dmcgowan
approved these changes
Feb 6, 2024
Member
Author
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Added unit tests for the CLI-plugin socket code, and added e2e tests covering the new functionality as well as backwards compatibility with older plugin binaries, as well as regressions for moby/moby#47073.
OH! There's also a commit making it so that we don't hardcode
amd64in the plugin e2e scripts, so that this works on arm too :)- How I did it
With a small dog on my lap! And by adding a new e2e test plugin.
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)
(not the aforementioned dog)