Skip to content
This repository was archived by the owner on Nov 27, 2023. It is now read-only.

Commit c13d165

Browse files
authored
Merge pull request #390 from chris-crone/readme-typos
Fix README typos
2 parents 6294843 + bf9b31e commit c13d165

File tree

1 file changed

+14
-14
lines changed

1 file changed

+14
-14
lines changed

README.md

+14-14
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ If you don't have or want to use Docker for building you need to make sure you h
1616

1717
And then you can call the same make targets but you need to pass it the `builder.Makefile` (`make -f builder.Makefile`).
1818

19-
The new CLI delegates to the classic docker for default contexts ; delegation is done to `com.docker.cli`.
19+
The new CLI delegates to the classic docker for default contexts ; delegation is done to `com.docker.cli`.
2020
* `make moby-cli-link` will create a `com.docker.cli` link in `/usr/local/bin` if you don't already have it from Docker Desktop
2121

2222
## Building the project
@@ -33,7 +33,7 @@ If you make changes to the `.proto` files, make sure to `make protos` to generat
3333

3434
## Tests
3535

36-
### unit tests
36+
### Unit tests
3737

3838
```
3939
make test
@@ -44,34 +44,34 @@ If you need to update a golden file simply do `go test ./... -test.update-golden
4444
### e2e tests
4545

4646
```
47-
make e2e_local
47+
make e2e-local
4848
```
49-
This requires a local docker engine running
49+
This requires a local Docker Engine running
5050

5151
```
52-
AZURE_TENANT_ID="xxx" AZURE_CLIENT_ID="yyy" AZURE_CLIENT_SECRET="yyy" make e2e_aci
52+
AZURE_TENANT_ID="xxx" AZURE_CLIENT_ID="yyy" AZURE_CLIENT_SECRET="yyy" make e2e-aci
5353
```
5454

55-
This requires azure service principal credentials to login to azure.
56-
To get the values to be set in local environment variables, you can create a new service principal once you're logged in azure (with `docker login azure`)
55+
This requires azure service principal credentials to login to azure.
56+
To get the values to be set in local environment variables, you can create a new service principal once you're logged in azure (with `docker login azure`)
5757
```
5858
az ad sp create-for-rbac --name 'MyTestServicePrincipal' --sdk-auth
5959
```
60-
Running aci e2e tests will override your local login, the service principal credentials use a token that cannot be refreshed automatically.
60+
Running the ACI e2e tests will override your local login, the service principal credentials use a token that cannot be refreshed automatically.
6161
You might need to run again `docker login azure` to properly use the command line after running ACI e2e tests.
6262

63-
You can also run a single ACI test from the test suite :
63+
You can also run a single ACI test from the test suite:
6464
```
6565
TESTIFY=TestACIRunSingleContainer AZURE_TENANT_ID="xxx" AZURE_CLIENT_ID="yyy" AZURE_CLIENT_SECRET="yyy" make e2e-aci
6666
```
6767

6868
## Release
6969

70-
To create a new release:
71-
* check that the CI is green on the master commit you want to release
72-
* simply create a new tag of th form vx.y.z, following existing tags, and push the tag
70+
To create a new release:
71+
* check that the CI is green on the master commit you want to release
72+
* simply create a new tag of the form vx.y.z, following existing tags, and push the tag
7373

74-
Pushing the tag will automatically ceate a new release and make binaries (mac, win, linux) available for download.
74+
Pushing the tag will automatically create a new release and make binaries (mac, win, linux) available for download.
7575

76-
Note: Linux binaries are not automatically copied to /docker/aci-integration-beta, if you want to make the linux binary publically available, you'll need to manually create a release in aci-integration-beta and upload the binary.
76+
Note: Linux binaries are not automatically copied to /docker/aci-integration-beta, if you want to make the linux binary publically available, you'll need to manually create a release in aci-integration-beta and upload the binary.
7777
For Desktop integration, you need to make a PR in /docker/pinata and update the cli release number [here](https://github.com/docker/pinata/blob/master/build.json#L25)

0 commit comments

Comments
 (0)