You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Nov 27, 2023. It is now read-only.
Copy file name to clipboardExpand all lines: README.md
+14-14
Original file line number
Diff line number
Diff line change
@@ -16,7 +16,7 @@ If you don't have or want to use Docker for building you need to make sure you h
16
16
17
17
And then you can call the same make targets but you need to pass it the `builder.Makefile` (`make -f builder.Makefile`).
18
18
19
-
The new CLI delegates to the classic docker for default contexts ; delegation is done to `com.docker.cli`.
19
+
The new CLI delegates to the classic docker for default contexts ; delegation is done to `com.docker.cli`.
20
20
*`make moby-cli-link` will create a `com.docker.cli` link in `/usr/local/bin` if you don't already have it from Docker Desktop
21
21
22
22
## Building the project
@@ -33,7 +33,7 @@ If you make changes to the `.proto` files, make sure to `make protos` to generat
33
33
34
34
## Tests
35
35
36
-
### unit tests
36
+
### Unit tests
37
37
38
38
```
39
39
make test
@@ -44,34 +44,34 @@ If you need to update a golden file simply do `go test ./... -test.update-golden
44
44
### e2e tests
45
45
46
46
```
47
-
make e2e_local
47
+
make e2e-local
48
48
```
49
-
This requires a local docker engine running
49
+
This requires a local Docker Engine running
50
50
51
51
```
52
-
AZURE_TENANT_ID="xxx" AZURE_CLIENT_ID="yyy" AZURE_CLIENT_SECRET="yyy" make e2e_aci
52
+
AZURE_TENANT_ID="xxx" AZURE_CLIENT_ID="yyy" AZURE_CLIENT_SECRET="yyy" make e2e-aci
53
53
```
54
54
55
-
This requires azure service principal credentials to login to azure.
56
-
To get the values to be set in local environment variables, you can create a new service principal once you're logged in azure (with `docker login azure`)
55
+
This requires azure service principal credentials to login to azure.
56
+
To get the values to be set in local environment variables, you can create a new service principal once you're logged in azure (with `docker login azure`)
57
57
```
58
58
az ad sp create-for-rbac --name 'MyTestServicePrincipal' --sdk-auth
59
59
```
60
-
Running aci e2e tests will override your local login, the service principal credentials use a token that cannot be refreshed automatically.
60
+
Running the ACI e2e tests will override your local login, the service principal credentials use a token that cannot be refreshed automatically.
61
61
You might need to run again `docker login azure` to properly use the command line after running ACI e2e tests.
62
62
63
-
You can also run a single ACI test from the test suite :
63
+
You can also run a single ACI test from the test suite:
64
64
```
65
65
TESTIFY=TestACIRunSingleContainer AZURE_TENANT_ID="xxx" AZURE_CLIENT_ID="yyy" AZURE_CLIENT_SECRET="yyy" make e2e-aci
66
66
```
67
67
68
68
## Release
69
69
70
-
To create a new release:
71
-
* check that the CI is green on the master commit you want to release
72
-
* simply create a new tag of th form vx.y.z, following existing tags, and push the tag
70
+
To create a new release:
71
+
* check that the CI is green on the master commit you want to release
72
+
* simply create a new tag of the form vx.y.z, following existing tags, and push the tag
73
73
74
-
Pushing the tag will automatically ceate a new release and make binaries (mac, win, linux) available for download.
74
+
Pushing the tag will automatically create a new release and make binaries (mac, win, linux) available for download.
75
75
76
-
Note: Linux binaries are not automatically copied to /docker/aci-integration-beta, if you want to make the linux binary publically available, you'll need to manually create a release in aci-integration-beta and upload the binary.
76
+
Note: Linux binaries are not automatically copied to /docker/aci-integration-beta, if you want to make the linux binary publically available, you'll need to manually create a release in aci-integration-beta and upload the binary.
77
77
For Desktop integration, you need to make a PR in /docker/pinata and update the cli release number [here](https://github.com/docker/pinata/blob/master/build.json#L25)
0 commit comments