Skip to content
This repository was archived by the owner on Nov 27, 2023. It is now read-only.

Commit 97560f8

Browse files
authored
Merge pull request #953 from docker/windows_e2e_docker_logout
On GH Actions windows nodes, ensure there is no automatic docker login before running ACI E2E tests
2 parents e984f76 + 1f8fbe5 commit 97560f8

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

.github/workflows/optional-ci.yml

+4-1
Original file line numberDiff line numberDiff line change
@@ -141,4 +141,7 @@ jobs:
141141
AZURE_CLIENT_ID: ${{ secrets.AZURE_CLIENT_ID }}
142142
AZURE_CLIENT_SECRET: ${{ secrets.AZURE_CLIENT_SECRET }}
143143
AZURE_TENANT_ID: ${{ secrets.AZURE_TENANT_ID }}
144-
run: make e2e-aci
144+
# need to docker logout on windows nodes, it seems GHActions does a `docker login --user githubactions` specifically on windows nodes
145+
run: |
146+
docker logout
147+
make e2e-aci

0 commit comments

Comments
 (0)