Skip to content
This repository was archived by the owner on Nov 27, 2023. It is now read-only.

Commit 849fbed

Browse files
authored
Merge pull request #1100 from docker/ecs-secrets-cleanup
Remove unnecessary retry in ECS secrets test
2 parents df4fed2 + 246b763 commit 849fbed

1 file changed

Lines changed: 0 additions & 5 deletions

File tree

tests/ecs-e2e/e2e-ecs_test.go

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -62,10 +62,6 @@ func TestSecrets(t *testing.T) {
6262

6363
t.Run("list secrets", func(t *testing.T) {
6464
res := cmd.RunDockerCmd("secret", "list")
65-
if !strings.Contains(res.Stdout(), secretName) { // test sometimes fail, it seems things might need a bit of time on the AWS side, trying once morez
66-
time.Sleep(1 * time.Second)
67-
res = cmd.RunDockerCmd("secret", "list")
68-
}
6965
assert.Check(t, strings.Contains(res.Stdout(), secretName), res.Stdout())
7066
})
7167

@@ -91,7 +87,6 @@ func TestCompose(t *testing.T) {
9187
var webURL, wordsURL, secretsURL string
9288
t.Run("compose ps", func(t *testing.T) {
9389
res := c.RunDockerCmd("compose", "ps", "--project-name", stack)
94-
fmt.Println(strings.TrimSpace(res.Stdout()))
9590
lines := strings.Split(strings.TrimSpace(res.Stdout()), "\n")
9691

9792
assert.Equal(t, 5, len(lines))

0 commit comments

Comments
 (0)