Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JavaScriptCore support #4

Open
MicheleLonghi opened this issue Sep 23, 2020 · 2 comments
Open

JavaScriptCore support #4

MicheleLonghi opened this issue Sep 23, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@MicheleLonghi
Copy link
Contributor

Allowing access to MIDIKit APIs from JS.
@dnadoba
Copy link
Owner

dnadoba commented Sep 23, 2020

Many types, especially MIDIMessage and types MIDIMessage uses, are enums with associated values.
I don't know a good way to expose those types to JS.

I think it's a nice idea for scripting purposes.
Do you think this can be done in separate Swift Package?

@MicheleLonghi
Copy link
Contributor Author

You're right. The library is nicely done as a pure Swift implementation.
The biggest issue is MIDIMessage indeed. It would be necessary to create specific JS types, like MIIDNoteOnMessage, only for the purpose.
TBH last time I used JSC was with ObjC, so I have to get back to it and better understand what can be done with Swift.
Cheers

@dnadoba dnadoba added the enhancement New feature or request label Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MicheleLonghi @dnadoba