Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev mode & code location #1

Open
adrexia opened this issue May 23, 2022 · 1 comment
Open

Dev mode & code location #1

adrexia opened this issue May 23, 2022 · 1 comment

Comments

@adrexia
Copy link

adrexia commented May 23, 2022

https://github.com/rafaeldsousa/silverstripe-securityheaders/blob/415fc9a61126a532a2bd47f89b49feaad5a692eb/src/extensions/SecurityHeadersExtension.php#L24

Could we remove this line, and enable/disable from yml instead? It's a lot easier to change a yml property to exclude dev than it is to switch environments over to test/live mode, and a more obvious place to look when debugging.

Namespaces: can we either change the composer namespace to rafaeldsousa, or move to the dnadesign github? It will make it more obvious where to look for this code

@rafaeldsousa
Copy link
Collaborator

@adrexia yep, lets do all of that, but first move the package to the dna repo (we'll just need to update all sites using this to point to that repo instead).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants