-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typescript definitions #53
Comments
I'll gladly email you mine, but they are nowhere near the quality needed to merge in. I'd love to get a PR! |
@dmurvihill thanks, that'll be great, maybe we'll get them together to a state ready for a PR. Would it make sense to commit them to a separate branch so I could propose changes to that branch if I would have additions to it? |
Pushed to dmurvihill:type-definitions. Have at it! One thing that would be a must is automated tests to make sure we don't cause regressions. |
@dmurvihill thank you very much, I will have a look at it. Regarding automated tests for typedefs, I have little experience so I will have to see if I can help there. |
Check this out: https://github.com/SamVerschueren/tsd |
Thanks for the lib. Are there typescript typings available somewhere so that firebase-mock can be used in typescript projects?
The text was updated successfully, but these errors were encountered: