Fix: an existing index == None should return False #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
looks like all the circleci tests are failing with sudo apt-get install -y postgresql-client
# E: Failed to fetch http://deb.debian.org/debian/pool/main/d/distro-info-data/distro-info-data_0.41+deb10u2_all.deb 404 # Not Found [IP: 199.232.166.132 80]
# E: Unable to fetch some archives, maybe run apt-get update or try with --fix-missing? |
Author
|
@djrobstep, requesting a review |
The option to omit lower or upper bound of an array slice seems to have been introduced between 9.5 and 9.6. See "Accessing Arrays" in https://www.postgresql.org/docs/9.5/arrays.html https://www.postgresql.org/docs/9.6/arrays.html
While using `migra`, I got the following error: `AttributeError: 'NoneType' object has no attribute 'name'`. Using `pdb`, I determined that the error arose when a table with an index was compared to one without an index. This patch eliminated the error.
Author
|
^ same problem |
djrobstep
force-pushed
the
master
branch
3 times, most recently
from
13f62b5 to
ebbc2e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While using
migra, I got the following error:AttributeError: 'NoneType' object has no attribute 'name'. Usingpdb, I determined that the error arose when a table with an index was compared to one without an index. This patch eliminated the error.