🔨 Collections Category/Group fixes #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jefftriplett
requested review from
logankilpatrick and
drewbrew
as code owners
drewbrew
approved these changes
Aug 28, 2022
_schedule/talks/2022-10-18-09-45-t0-come-on-in-the-waters-fine-making-python.md
Outdated
Show resolved
Hide resolved
| layout: session-details | ||
| schedule_layout: full | ||
| permalink: /social-event/board-game-night/ | ||
| permalink: /social-events/board-game-night/ |
There was a problem hiding this comment.
I need to check if the board game night post links here
There was a problem hiding this comment.
I didn't see it referenced in the post.
_schedule/talks/2022-10-19-09-45-t0-keynote-state-of-the-object-relational.md
Outdated
Show resolved
Hide resolved
|
@drewbrew good catch. I'm won't merge until we sort it out. This has bitten us in the past, and I see a one-liner that I think will fix it going forward. I'll push and fix. |
jefftriplett
commented
Aug 28, 2022
|
Will follow up with a better perma-fix, but short term the process.py script won't regenerate permalinks once they are set. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #169.
This is a workaround for Jekyll Collections (no clue when this changed) using category == subfolder instead of what we assign it. I updated
process.pyto validate/fix/sync and re-ran it over our schedule data.