Fix: resolve 500 error when creating product with null attribute value (#374)

Author: mfarhan943

oscarapi/serializers/product.py

@@ -276,7 +276,7 @@ def to_internal_value(self, data):
 
     def get_value(self, dictionary):
         values = super(ProductAttributeValueListSerializer, self).get_value(dictionary)
-        if values is empty:
+        if not values or values is empty:
             return values
 
         product_class, parent = getitems(dictionary, "product_class", "parent")

oscarapi/tests/unit/testproduct.py

@@ -1750,6 +1750,13 @@ def test_put_product_ambiguous(self):
         )
         self.response.assertStatusEqual(404)
 
+    def test_post_product_with_null_attributes(self):
+        "Test creating a product with null attributes should return a 400 Bad Request"
+        self.login("admin", "admin")
+        data = {"product_class": "testtype", "slug": "test", "attributes": None}
+        self.response = self.post("admin-product-list", **data)
+        self.response.assertStatusEqual(400)
+
     def test_put_child(self):
         self.login("admin", "admin")
         url = reverse("admin-product-detail", args=(2,))