Skip to content

Commit b73e3ad

Browse files
committed
remove pdf rtd build - sphinx tabs doesnt work on it
1 parent 93ec4ee commit b73e3ad

File tree

6 files changed

+17
-132
lines changed

6 files changed

+17
-132
lines changed

CONTRIBUTING.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,6 @@ benchmark # generate and document benchmarks
9898
build # build src package and wheel
9999
build-docs # build the docs
100100
build-docs-html # build html documentation
101-
build-docs-pdf # build pdf documentation
102101
check # run all static checks
103102
check-docs # lint the documentation
104103
check-docs-links # check the documentation links for broken links

doc/.readthedocs.yaml

Lines changed: 3 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -10,18 +10,7 @@ build:
1010
os: ubuntu-22.04
1111
tools:
1212
python: "3.12"
13-
apt_packages:
14-
- libcairo2
15-
- libpango-1.0-0
16-
- libgdk-pixbuf2.0-0
17-
- libffi-dev
18-
- chromium-browser
19-
- libasound2
2013
jobs:
21-
post_create_environment:
22-
- wget https://dl.google.com/linux/direct/google-chrome-stable_current_amd64.deb
23-
- dpkg -x google-chrome-stable_current_amd64.deb $HOME/chrome
24-
- touch $HOME/.rtd.build
2514
post_install:
2615
- pip install uv
2716
- UV_PROJECT_ENVIRONMENT=$READTHEDOCS_VIRTUALENV_PATH uv sync --all-extras --group docs --link-mode=copy
@@ -31,5 +20,6 @@ sphinx:
3120
configuration: doc/source/conf.py
3221

3322
# Optionally build your docs in additional formats such as PDF and ePub
34-
formats:
35-
- pdf
23+
# remove pdf for now - sphinx tabs does not support
24+
# formats:
25+
# - pdf

doc/source/performance.rst

Lines changed: 4 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -30,14 +30,9 @@ uninstall :pypi:`rich`. As of :pypi:`Typer` 0.17, :pypi:`rich` is lazily loaded,
3030
improvements <https://github.com/django-commons/django-typer/issues/170>`_ are made to :pypi:`Typer`
3131
, the import time penalty is still incurred by :pypi:`django-typer`.
3232

33-
.. only:: html
33+
.. raw:: html
34+
:file: _static/img/minimal_profile.svg
3435

35-
.. raw:: html
36-
:file: _static/img/minimal_profile.svg
37-
38-
.. only:: latex
39-
40-
.. literalinclude:: _static/img/minimal_profile.txt
4136

4237
The second benchmark shows the same stats for the :ref:`polls example code <building_commands>`.
4338
These benchmarks compare the :class:`~django.core.management.BaseCommand` native implementation
@@ -46,11 +41,6 @@ using :pypi:`django-typer` is minimal. On the order of a few 10s of milliseconds
4641
:pypi:`rich` increases this overhead slightly, but the impact is still barely noticeable.
4742

4843

49-
.. only:: html
50-
51-
.. raw:: html
52-
:file: _static/img/polls_profile.svg
53-
54-
.. only:: latex
44+
.. raw:: html
45+
:file: _static/img/polls_profile.svg
5546

56-
.. literalinclude:: _static/img/polls_profile.txt

justfile

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -105,17 +105,16 @@ clean: clean-docs clean-git-ignored clean-env
105105
build-docs-html: install-docs
106106
@just run sphinx-build --fresh-env --builder html --doctree-dir ./doc/build/doctrees ./doc/source ./doc/build/html
107107

108-
[script]
109-
_open-pdf-docs:
110-
import webbrowser
111-
from pathlib import Path
112-
webbrowser.open(f"file://{Path('./doc/build/pdf/django-typer.pdf').absolute()}")
113-
114-
# build pdf documentation
115-
build-docs-pdf: install-docs
116-
@just run sphinx-build --fresh-env --builder latex --doctree-dir ./doc/build/doctrees ./doc/source ./doc/build/pdf
117-
make -C ./doc/build/pdf
118-
@just _open-pdf-docs
108+
# [script]
109+
# _open-pdf-docs:
110+
# import webbrowser
111+
# from pathlib import Path
112+
# webbrowser.open(f"file://{Path('./doc/build/pdf/django-typer.pdf').absolute()}")
113+
# # build pdf documentation
114+
# build-docs-pdf: install-docs
115+
# @just run sphinx-build --fresh-env --builder latex --doctree-dir ./doc/build/doctrees ./doc/source ./doc/build/pdf
116+
# make -C ./doc/build/pdf
117+
# @just _open-pdf-docs
119118

120119
# build the docs
121120
build-docs: build-docs-html

pyproject.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -201,7 +201,6 @@ docs = [
201201
"sphinx-autobuild>=2024.10.3",
202202
"sphinx-tabs>=3.4.7",
203203
"sphinxcontrib-django>=2.5",
204-
"sphinxcontrib-svg2pdfconverter[cairosvg]>=1.3.0",
205204
"sphinxcontrib-typer[png]>=0.5.1",
206205
]
207206
profiling = [

uv.lock

Lines changed: 0 additions & 92 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)