Skip to content

Commit b71ef3f

Browse files
committed
Move SetContentTypes into ExportSettings
Fixes a small bug where the editor and exporter had different opinions on what a mod contained
1 parent dc77b08 commit b71ef3f

File tree

3 files changed

+21
-30
lines changed

3 files changed

+21
-30
lines changed

Disunity/Disunity.Editor/Editors/ExportEditor.cs

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -67,19 +67,7 @@ private void DrawDetails(ExportSettings settings) {
6767
}
6868

6969
private void DrawContentWarning(ExportSettings settings) {
70-
71-
settings.ContentTypes = 0;
72-
if (settings.PreloadAssemblies.Length > 0)
73-
settings.ContentTypes |= ContentType.PreloadAssemblies;
74-
if (settings.RuntimeAssemblies.Length > 0)
75-
settings.ContentTypes |= ContentType.RuntimeAssemblies;
76-
if (settings.Prefabs.Length > 0)
77-
settings.ContentTypes |= ContentType.Prefabs;
78-
if (settings.Scenes.Length > 0)
79-
settings.ContentTypes |= ContentType.Scenes;
80-
if (settings.Artifacts.Length > 0)
81-
settings.ContentTypes |= ContentType.Artifacts;
82-
70+
settings.UpdateContentTypes();
8371
if (settings.ContentTypes == 0) {
8472
throw new ExportValidationError("You must include some content in your mod.");
8573
}

Disunity/Disunity.Editor/Export.cs

Lines changed: 1 addition & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -79,22 +79,6 @@ private List<string> ExportAssemblies(UnityEngine.Object[] assemblies, string fo
7979
return destinations;
8080
}
8181

82-
private void SetContentTypes() {
83-
_settings.ContentTypes = 0;
84-
if (_settings.PreloadAssemblies.Length > 0) {
85-
_settings.ContentTypes |= ContentType.PreloadAssemblies;
86-
}
87-
if (_settings.RuntimeAssemblies.Length > 0) {
88-
_settings.ContentTypes |= ContentType.RuntimeAssemblies;
89-
}
90-
if (_settings.Prefabs.Length > 0) {
91-
_settings.ContentTypes |= ContentType.Prefabs;
92-
}
93-
if (_settings.Scenes.Length > 0) {
94-
_settings.ContentTypes |= ContentType.Scenes;
95-
}
96-
}
97-
9882
private List<string> ExportRuntimeAssemblies() {
9983
return ExportAssemblies(_settings.RuntimeAssemblies, "runtime");
10084
}
@@ -162,7 +146,7 @@ public void Run() {
162146
var runtimeAssemblies = ExportRuntimeAssemblies();
163147
ExportCopyAssets();
164148
ExportModAssets();
165-
SetContentTypes();
149+
_settings.UpdateContentTypes();
166150
SaveMetadata(preloadAssemblies, runtimeAssemblies);
167151
CopyToOutput();
168152
}

Disunity/Disunity.Editor/ExportSettings.cs

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,25 @@ public class ExportSettings : ScriptableObject {
4949

5050
[field: SerializeField] public string PreloadAssembly { get; set; }
5151

52+
public void UpdateContentTypes() {
53+
ContentTypes = 0;
54+
if (PreloadAssemblies.Length > 0) {
55+
ContentTypes |= ContentType.PreloadAssemblies;
56+
}
57+
if (RuntimeAssemblies.Length > 0) {
58+
ContentTypes |= ContentType.RuntimeAssemblies;
59+
}
60+
if (Prefabs.Length > 0) {
61+
ContentTypes |= ContentType.Prefabs;
62+
}
63+
if (Scenes.Length > 0) {
64+
ContentTypes |= ContentType.Scenes;
65+
}
66+
if (Artifacts.Length > 0) {
67+
ContentTypes |= ContentType.Artifacts;
68+
}
69+
}
70+
5271
}
5372

5473
}

0 commit comments

Comments
 (0)