-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(GuildAuditLogEntry)!: Fix some incorrect types and runtime logic #10591
Open
cobaltt7
wants to merge
22
commits into
discordjs:main
Choose a base branch
from
cobaltt7:audit-log-types
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+49
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
cobaltt7
changed the title
types(GuildAuditLogEntry): Fix some incorrect types
fix(GuildAuditLogEntry): Fix some incorrect types and runtime logic
Nov 6, 2024
Jiralite
changed the title
fix(GuildAuditLogEntry): Fix some incorrect types and runtime logic
fix(GuildAuditLogEntry)!: Fix some incorrect types and runtime logic
Nov 13, 2024
#10521 already covers half of these changes. |
Please resolve conflicts! |
Signed-off-by: cobalt <[email protected]>
Resolved conflicts and removed the overlapping changes. Sorry, I hadn't realized that PR existed! |
Hmm, some of these breaking changes sound like we should patch in existing 14 version too... @discordjs/core thoughts? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Fixes some audit log types and runtime logic.
MessageBulkDelete
is a channel, not a guildoptions.channel_id
, so I stopped.extra.channel
from being set to{ id: undefined }
User
as a target, not theAutoModerationRule
AutoModerationRule
GuildOnboardingCreate
andGuildOnboardingUpdate
do not have any targetTargets.GuildOnboarding
, it will fallback toTargets.Unknown
and generate a placeholdertarget
from thechanges
SoundboardSound
as much as possible right now, add placeholders for after feat: add soundboard #10590AutoModerationRule
rulesPartialUser
in the types where a partial user is possibleGuildAuditLogsEntry.Target
static objectRole
andEmoji
targets at runtime{ id: Snowflake }
alternative for if they were uncachedStatus and versioning classification:
There are some breaking changes, but they all are minor things that never worked properly.