Fix tests.

Author: VaibhaveS

docs/include/copy-db.rst

@@ -22,4 +22,5 @@
      --resume              Allow resuming operations after a failure
      --not-consistent      Allow taking a new snapshot on the source database
      --snapshot            Use snapshot obtained with pg_export_snapshot
+     --use-copy-binary     Use the COPY BINARY format for COPY operations
    

src/bin/pgcopydb/cli_copy.c

@@ -52,7 +52,8 @@ static CommandLine copy_db_command =
 		"  --restart             Allow restarting when temp files exist already\n"
 		"  --resume              Allow resuming operations after a failure\n"
 		"  --not-consistent      Allow taking a new snapshot on the source database\n"
-		"  --snapshot            Use snapshot obtained with pg_export_snapshot\n",
+		"  --snapshot            Use snapshot obtained with pg_export_snapshot\n"
+		"  --use-copy-binary     Use the COPY BINARY format for COPY operations\n",
 		cli_copy_db_getopts,
 		cli_clone);
 

src/bin/pgcopydb/pgsql.h

@@ -337,7 +337,6 @@ typedef struct CopyArgs
 	bool truncate;
 	bool freeze;
 	bool useCopyBinary;
-	uint64_t bytesTransmitted;
 } CopyArgs;
 
 

src/bin/pgcopydb/table-data.c

@@ -1129,7 +1129,6 @@ copydb_table_create_lockfile(CopyDataSpec *specs,
 	args->dstAttrList = tableSpecs->sourceTable->attrList;
 	args->truncate = false;     /* default value, see below */
 	args->freeze = tableSpecs->sourceTable->partition.partCount <= 1;
-	args->bytesTransmitted = 0;
 	args->useCopyBinary = specs->useCopyBinary;
 
 	/*

tests/endpos-in-multi-wal-txn/copydb.sh

@@ -34,7 +34,7 @@ sleep 1
 pgcopydb stream setup
 
 # pgcopydb clone uses the environment variables
-pgcopydb clone --use-binary-copy
+pgcopydb clone --use-copy-binary
 
 # now that the copying is done, inject some SQL DML changes to the source
 psql -d ${PGCOPYDB_SOURCE_PGURI} -f /usr/src/pgcopydb/multi-wal-txn.sql