Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App behavior undefined when blockchain changes #87

Open
jonathanraes opened this issue Jun 5, 2017 · 1 comment
Open

App behavior undefined when blockchain changes #87

jonathanraes opened this issue Jun 5, 2017 · 1 comment
Labels

Comments

@jonathanraes
Copy link
Collaborator

The app assumes the network parameters. What happens if these are no longer valid?

@landgenoot
Copy link
Member

landgenoot commented Jun 10, 2017

It crashes with:

15:48:35.164 [NioClientManager] INFO  org.bitcoinj.core.PeerGroup - [188.226.149.56]:6799: Peer died      (0 connected, 0 pending, 1 max)
15:48:35.169 [PeerGroup Thread] INFO  org.bitcoinj.core.PeerGroup - Peer discovery took 77.62 μs and returned 0 items
15:48:35.171 [PeerGroup Thread] INFO  org.bitcoinj.core.PeerGroup - Waiting 599999 msec before next connect attempt to [188.226.149.56]:6799
15:48:35.175 [NioClientManager] WARN  org.bitcoinj.net.NioClientManager - Failed to connect with exception: java.nio.channels.ClosedChannelException: null
java.nio.channels.ClosedChannelException: null
	at sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:721) ~[na:0.0]
	at org.bitcoinj.net.NioClientManager.handleKey(NioClientManager.java:64) ~[na:0.0]
	at org.bitcoinj.net.NioClientManager.run(NioClientManager.java:122) ~[na:0.0]
	at com.google.common.util.concurrent.AbstractExecutionThreadService$1$2.run(AbstractExecutionThreadService.java:60) ~[na:0.0]
	at com.google.common.util.concurrent.Callables$3.run(Callables.java:95) ~[na:0.0]
	at org.bitcoinj.utils.ContextPropagatingThreadFactory$1.run(ContextPropagatingThreadFactory.java:51) ~[na:0.0]
	at java.lang.Thread.run(Thread.java:762) ~[na:0.0]

And it just starts up without this peer.

Maybe add a notification if it cannot connect to any of the peers?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants