Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navbar Linebreak on Mobile #45

Open
mtwente opened this issue Aug 21, 2024 · 4 comments
Open

Navbar Linebreak on Mobile #45

mtwente opened this issue Aug 21, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@mtwente
Copy link
Contributor

mtwente commented Aug 21, 2024

Current Behavior

On smaller screens, the search box logo (the last one) is placed on a new line, when the navbar should have one line only:
Bildschirmfoto 2024-08-21 um 21 28 41

On medium screens, both the github icon and the darkmode toggle are not aligned properly. They should be placed on the far right, next to the search button.

Bildschirmfoto 2024-08-21 um 21 29 45

Reproduction / Steps To Reproduce

No response

Anything else?

No response

@mtwente mtwente added the bug Something isn't working label Aug 21, 2024
@maehr
Copy link
Contributor

maehr commented Aug 21, 2024

A quick fix is to turn of dark mode. To fix it we would need to fix the quarto template. It looks a little messy, especially the aa-DetachedSearchButton class...

@maehr
Copy link
Contributor

maehr commented Aug 21, 2024

Alternatively we could uncomment the following section in _quarto.yml

    # tools:
    #   - icon: github
    #     url: https://github.com/digihistch24/book-of-abstracts/
    #     target: _blank

@mtwente
Copy link
Contributor Author

mtwente commented Aug 22, 2024

Yes. Each abstract page has a separate link to edit on github anyway.
But also, neither dark mode nor this icon are really necessary...

@maehr
Copy link
Contributor

maehr commented Aug 22, 2024

Fair point. Let's discuss this later today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants