New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[py] better error messages for snapshot mismatch #501

Open

nedtwigg opened this issue Dec 16, 2024 · 0 comments

Labels

Member

nedtwigg commented Dec 16, 2024

There's some unimplemented code here

selfie/python/selfie-lib/selfie_lib/SnapshotSystem.py

Lines 127 to 128 in 51fefff

    
           def msg_snapshot_mismatch(self, expected: str, actual: str) -> str:  # noqa: ARG002 
        
               return self.msg("Snapshot mismatch, TODO: string comparison")

it should be implemented by porting these
- https://github.com/diffplug/selfie/blob/main/jvm/selfie-lib/src/commonMain/kotlin/com/diffplug/selfie/guts/SnapshotNotEqualErrorMsg.kt
- https://github.com/diffplug/selfie/blob/main/jvm/selfie-lib/src/commonTest/kotlin/com/diffplug/selfie/guts/SnapshotNotEqualErrorMsgTest.kt

Great first issue, would be a big UX improvement.

nedtwigg added py enhancement labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment