Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Engine heuristic: fix for assumptions unsupported by k-induction #923

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

kroening
Copy link
Member

@kroening kroening commented Jan 6, 2025

The k-induction engine now correctly reports unsupported assumptions, and is then skipped by the engine selection heuristic.

Fixes #921.

@kroening kroening force-pushed the k-induction6-fix branch 7 times, most recently from c568427 to 7cb3f0a Compare January 15, 2025 22:15
The k-induction engine now correctly reports unsupported assumptions, and is
then skipped by the engine selection heuristic.

Fixes #921.
@kroening kroening marked this pull request as ready for review January 16, 2025 18:23
Comment on lines +699 to 700
prop_handles.clear();
prop_handles.resize(no_timeframes, true_exprt());
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is now always cleared shouldn't this be returned by value rather than being required as argument?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, will action.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be separate PR.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kroening kroening merged commit f334106 into main Jan 16, 2025
9 checks passed
@kroening kroening deleted the k-induction6-fix branch January 16, 2025 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem with engine heuristic
2 participants