Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ebmc: add waveform output #227

Merged
merged 1 commit into from
Dec 3, 2023
Merged

ebmc: add waveform output #227

merged 1 commit into from
Dec 3, 2023
+206 −4

Conversation

kroening
Copy link
Member

@kroening kroening commented Dec 2, 2023

This adds a "horizontal" output format for traces, where the timeframe is on the x axis and the identifier of the state variable are on the y axis.

@kroening kroening marked this pull request as ready for review December 2, 2023 20:56
tautschnig
tautschnig approved these changes Dec 3, 2023
View reviewed changes
Copy link
Collaborator

@tautschnig tautschnig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Could this please be mentioned in --help output?
  2. Is this format understood by other tools (gtkwave?) or otherwise standardized? If so, it would be great to mention this somewhere.

@kroening
ebmc: add waveform output
407de3a 
This adds a "horizontal" output format for traces, where the timeframe is on
the x axis and the identifier of the state variable are on the y axis.
@kroening
Copy link
Member Author

kroening commented Dec 3, 2023

  1. Done
  2. gtkwave reads VCD!

@tautschnig
Copy link
Collaborator

[...]

2. gtkwave reads VCD!

That's what I thought so I was wondering whether it perhaps also supported such an input, or whether some other tool did so? If we are making up our own format that's surely ok, but I think it might be worth explicitly noting this.

@kroening kroening merged commit a1b07c2 into main Dec 3, 2023
@kroening kroening deleted the waveform branch December 3, 2023 22:46
@kroening
Copy link
Member Author

kroening commented Dec 3, 2023

That's what I thought so I was wondering whether it perhaps also supported such an input, or whether some other tool did so? If we are making up our own format that's surely ok, but I think it might be worth explicitly noting this.

It's not a file format, it's human-readable!

@tautschnig
Copy link
Collaborator

That's what I thought so I was wondering whether it perhaps also supported such an input, or whether some other tool did so? If we are making up our own format that's surely ok, but I think it might be worth explicitly noting this.

It's not a file format, it's human-readable!

Ah, I hadn't thought that this was mainly aimed at humans rather than post-processing by some other tool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tautschnig tautschnig tautschnig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kroening @tautschnig