From e5ec41b7c420c7e657a47f8cddddc0735e858bbb Mon Sep 17 00:00:00 2001
From: Daniel Kroening <dkr@amazon.com>
Date: Fri, 24 Jan 2025 16:29:03 -0800
Subject: [PATCH] Verilog: allow task invocations without parentheses

---
 regression/verilog/tasks/task_invocation1.desc |  3 +--
 src/verilog/parser.y                           | 16 +++++++++++++---
 2 files changed, 14 insertions(+), 5 deletions(-)

diff --git a/regression/verilog/tasks/task_invocation1.desc b/regression/verilog/tasks/task_invocation1.desc
index e15030bc..e7d3968e 100644
--- a/regression/verilog/tasks/task_invocation1.desc
+++ b/regression/verilog/tasks/task_invocation1.desc
@@ -1,4 +1,4 @@
-KNOWNBUG
+CORE
 task_invocation1.sv
 
 ^EXIT=0$
@@ -6,4 +6,3 @@ task_invocation1.sv
 --
 ^warning: ignoring
 --
-The parser rejects invocations without ().
diff --git a/src/verilog/parser.y b/src/verilog/parser.y
index a041d68f..7cfc0685 100644
--- a/src/verilog/parser.y
+++ b/src/verilog/parser.y
@@ -4007,7 +4007,7 @@ unsigned_number: TOK_NUMBER
 // A.8.2 Subroutine calls
 
 tf_call:
-          hierarchical_tf_identifier list_of_arguments_paren
+	  hierarchical_identifier list_of_arguments_paren_opt
 		{ init($$, ID_function_call);
 		  stack_expr($$).operands().reserve(2);
 		  mto($$, $1); mto($$, $2); }
@@ -4020,6 +4020,7 @@ list_of_arguments_paren:
 
 list_of_arguments_paren_opt:
 	  /* Optional */
+		{ init($$); }
 	| list_of_arguments_paren
 	;
 
@@ -4054,8 +4055,17 @@ subroutine_call:
         | system_tf_call
         ;
 
-function_subroutine_call: subroutine_call
-        ;
+// We deviate from the 1800-2017 grammar to remove the ambiguity
+// between function calls without parentheses and variables.
+// Note that this does not affect system function identifiers ($...),
+// which cannot be variables.
+function_subroutine_call:
+          hierarchical_tf_identifier list_of_arguments_paren
+		{ init($$, ID_function_call);
+		  stack_expr($$).operands().reserve(2);
+		  mto($$, $1); mto($$, $2); }
+	| system_tf_call
+	;
 
 event_trigger: TOK_MINUSGREATER hierarchical_event_identifier ';'
 		{ init($$, ID_verilog_event_trigger); mto($$, $2); }