BUG-ID : 59160 , fix extracting host for ipv6 address

FROZENCADET · web-flow · commit e0a636389911 · 2024-10-03T13:59:11.000+05:30
diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/ssh/Scp.java b/src/main/org/apache/tools/ant/taskdefs/optional/ssh/Scp.java
@@ -435,7 +435,8 @@ private String parseUri(final String uri) {
             throw new BuildException("no username was given.  Can't authenticate.");
         }
 
-        final int indexOfPath = uri.indexOf(':', indexOfAt + 1);
+        // For IPv6 address having more than one ":", it should look for the last occurrence
+        final int indexOfPath = uri.lastIndexof(':');
         if (indexOfPath == -1) {
             throw new BuildException("no remote path in %s", uri);
         }

Original file line number	Diff line number	Diff line change
`@@ -435,7 +435,8 @@ private String parseUri(final String uri) {`
`435`	`435`	`throw new BuildException("no username was given. Can't authenticate.");`
`436`	`436`	`}`
`437`	`437`
`438`		`- final int indexOfPath = uri.indexOf(':', indexOfAt + 1);`
	`438`	`+ // For IPv6 address having more than one ":", it should look for the last occurrence`
	`439`	`+ final int indexOfPath = uri.lastIndexof(':');`
`439`	`440`	`if (indexOfPath == -1) {`
`440`	`441`	`throw new BuildException("no remote path in %s", uri);`
`441`	`442`	`}`