Skip to content

Commit d212483

Browse files
committed
remove unused simian tool
1 parent 2dc4ca2 commit d212483

File tree

2 files changed

+1
-52
lines changed

2 files changed

+1
-52
lines changed

check.xml

Lines changed: 1 addition & 51 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919

2020
<description>
2121
Check Ant codebase against certain code style guidelines using
22-
Checkstyle, Apache Rat, SpotBugs, OWASP Dependency Check, Simian
22+
Checkstyle, Apache Rat, SpotBugs, OWASP Dependency Check
2323
and Nu Html Checker (v.Nu).
2424

2525
Checkstyle uses an abstract syntax tree (AST) for doing checks
@@ -37,11 +37,6 @@
3737
available at https://www.owasp.org/index.php/OWASP_Dependency_Check under
3838
Apache License, Version 2.0.
3939

40-
"Simian (Similarity Analyser) identifies duplication in Java, C#, C, CPP,
41-
COBOL, Ruby, JSP, ASP, HTML, XML, Visual Basic, Groovy source code and even
42-
plain text files." It is available at https://www.harukizaemon.com/simian/
43-
and is for free use in open source projects.
44-
4540
"The Nu Html Checker (v.Nu) is the backend of checker.html5.org,
4641
html5.validator.nu, and validator.w3.org/nu." It is available at
4742
https://validator.github.io/validator/ under MIT license.
@@ -114,20 +109,6 @@
114109
value="${rat.report.dir}/report.html"
115110
description="Name of Apache Rat report"/>
116111

117-
<!-- Simian -->
118-
<property name="simian.version"
119-
value="2.5.10"
120-
description="Which version of Simian to use"/>
121-
<property name="simian.uri"
122-
value="http://www.harukizaemon.com/simian/simian-${simian.version}.tar.gz"
123-
description="Where to get Simian"/>
124-
<property name="simian.lib.dir"
125-
value="${build.dir}/simian-lib"
126-
description="Where to store Simian resources"/>
127-
<property name="simian.report.dir"
128-
value="${reports.dir}/simian"
129-
description="Where to store Simian reports"/>
130-
131112
<!-- OWASP Dependency Check -->
132113
<property name="owasp.dc.version"
133114
value="3.2.1"
@@ -223,37 +204,6 @@
223204
</concat>
224205
</target>
225206

226-
<target name="simiancheck" description="--> runs the check for duplicates">
227-
<available property="simian.jar.present" file="${simian.lib.dir}/simian-${simian.version}.jar"/>
228-
<sequential unless:set="simian.jar.present">
229-
<echo>Install Simian ${simian.version}</echo>
230-
<mkdir dir="${simian.lib.dir}"/>
231-
<get src="${simian.uri}" dest="${simian.lib.dir}"/>
232-
<gunzip src="${simian.lib.dir}/simian-${simian.version}.tar.gz" dest="${simian.lib.dir}/simian-${simian.version}.tar"/>
233-
<untar src="${simian.lib.dir}/simian-${simian.version}.tar" dest="${simian.lib.dir}">
234-
<patternset>
235-
<include name="**/simian*.jar"/>
236-
<include name="**/simian*.xsl"/>
237-
</patternset>
238-
<flattenmapper/>
239-
</untar>
240-
</sequential>
241-
242-
<echo>Run Simian</echo>
243-
<taskdef resource="simiantask.properties">
244-
<classpath>
245-
<fileset dir="${simian.lib.dir}" includes="*.jar"/>
246-
</classpath>
247-
</taskdef>
248-
<mkdir dir="${simian.report.dir}"/>
249-
<simian failureProperty="simian.duplicates.found">
250-
<fileset dir="${java.dir}"/>
251-
<formatter type="plain" toFile="${simian.report.dir}/simian-log.txt"/>
252-
<formatter type="xml" toFile="${simian.report.dir}/simian-log.xml"/>
253-
</simian>
254-
<xslt in="${simian.report.dir}/simian-log.xml" style="${simian.lib.dir}/simian.xsl" out="${simian.report.dir}/simian.html"/>
255-
</target>
256-
257207
<target name="fixTS" description="--> fix checkstyle errors 'Line has trailing spaces'">
258208
<fail message="Define path to java file 'path'">
259209
<condition><not><isset property="path"/></not></condition>

src/etc/checkstyle/checkstyle-config

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,6 @@
129129
<property name="format" value="\s+$"/>
130130
</module>
131131

132-
<!-- <module name="au.com.redhillconsulting.simian.SimianCheck"/> -->
133132
<module name="SuppressionCommentFilter">
134133
<property name="offCommentFormat" value="CheckStyle\:([\w\|]+) *OFF"/>
135134
<property name="onCommentFormat" value="CheckStyle\:([\w\|]+) *ON"/>

0 commit comments

Comments
 (0)