Fixed segfault when handling many AI entities on testmaps/test_lotsaimps due to null root or children.

Author: klaussilveira

neo/d3xp/ai/AI_pathing.cpp

@@ -903,21 +903,27 @@ bool FindOptimalPath( const pathNode_t *root, const obstacle_t *obstacles, int n
 		}
 	}
 
-	if ( !pathToGoalExists ) {
-		seekPos.ToVec2() = root->children[0]->pos;
-	} else if ( !optimizedPathCalculated ) {
-		OptimizePath( root, bestNode, obstacles, numObstacles, optimizedPath );
-		seekPos.ToVec2() = optimizedPath[1];
-	}
+	if ( root != NULL ) {
+		if ( !pathToGoalExists ) {
+			if ( root->children[0] != NULL ) {
+				seekPos.ToVec2() = root->children[0]->pos;
+			} else {
+				seekPos.ToVec2() = root->pos;
+			}
+		} else if ( !optimizedPathCalculated ) {
+			OptimizePath( root, bestNode, obstacles, numObstacles, optimizedPath );
+			seekPos.ToVec2() = optimizedPath[1];
+		}
 
-	if ( ai_showObstacleAvoidance.GetBool() ) {
-		idVec3 start, end;
-		start.z = end.z = height + 4.0f;
-		numPathPoints = OptimizePath( root, bestNode, obstacles, numObstacles, optimizedPath );
-		for ( i = 0; i < numPathPoints-1; i++ ) {
-			start.ToVec2() = optimizedPath[i];
-			end.ToVec2() = optimizedPath[i+1];
-			gameRenderWorld->DebugArrow( colorCyan, start, end, 1 );
+		if ( ai_showObstacleAvoidance.GetBool() ) {
+			idVec3 start, end;
+			start.z = end.z = height + 4.0f;
+			numPathPoints = OptimizePath( root, bestNode, obstacles, numObstacles, optimizedPath );
+			for ( i = 0; i < numPathPoints-1; i++ ) {
+				start.ToVec2() = optimizedPath[i];
+				end.ToVec2() = optimizedPath[i+1];
+				gameRenderWorld->DebugArrow( colorCyan, start, end, 1 );
+			}
 		}
 	}
 

neo/game/ai/AI_pathing.cpp

@@ -906,21 +906,27 @@ bool FindOptimalPath( const pathNode_t *root, const obstacle_t *obstacles, int n
 		}
 	}
 
-	if ( !pathToGoalExists ) {
-		seekPos.ToVec2() = root->children[0]->pos;
-	} else if ( !optimizedPathCalculated ) {
-		OptimizePath( root, bestNode, obstacles, numObstacles, optimizedPath );
-		seekPos.ToVec2() = optimizedPath[1];
-	}
+	if ( root != NULL ) {
+		if ( !pathToGoalExists ) {
+			if ( root->children[0] != NULL ) {
+				seekPos.ToVec2() = root->children[0]->pos;
+			} else {
+				seekPos.ToVec2() = root->pos;
+			}
+		} else if ( !optimizedPathCalculated ) {
+			OptimizePath( root, bestNode, obstacles, numObstacles, optimizedPath );
+			seekPos.ToVec2() = optimizedPath[1];
+		}
 
-	if ( ai_showObstacleAvoidance.GetBool() ) {
-		idVec3 start, end;
-		start.z = end.z = height + 4.0f;
-		numPathPoints = OptimizePath( root, bestNode, obstacles, numObstacles, optimizedPath );
-		for ( i = 0; i < numPathPoints-1; i++ ) {
-			start.ToVec2() = optimizedPath[i];
-			end.ToVec2() = optimizedPath[i+1];
-			gameRenderWorld->DebugArrow( colorCyan, start, end, 1 );
+		if ( ai_showObstacleAvoidance.GetBool() ) {
+			idVec3 start, end;
+			start.z = end.z = height + 4.0f;
+			numPathPoints = OptimizePath( root, bestNode, obstacles, numObstacles, optimizedPath );
+			for ( i = 0; i < numPathPoints-1; i++ ) {
+				start.ToVec2() = optimizedPath[i];
+				end.ToVec2() = optimizedPath[i+1];
+				gameRenderWorld->DebugArrow( colorCyan, start, end, 1 );
+			}
 		}
 	}