Skip to content

Commit 601e8a9

Browse files
committedMar 31, 2020
error handling around fetching releases from github
1 parent 8b2dd58 commit 601e8a9

File tree

2 files changed

+24
-4
lines changed

2 files changed

+24
-4
lines changed
 

‎.github/workflows/main.yml

+7-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,10 @@
1-
on: [push]
1+
on:
2+
push:
3+
paths:
4+
- src/*
5+
- action.yml
6+
- package.json
7+
- package-lock.json
28

39
jobs:
410
build:

‎src/action.js

+17-3
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,17 @@ const fetchReleases = async () => {
3333

3434
core.info(`Fetching dhall releases from ${url}`)
3535

36-
const release = JSON.parse(await get(url))
36+
let release
37+
38+
try {
39+
release = JSON.parse(await get(url))
40+
} catch (error) {
41+
core.setFailed(
42+
`Failed to fetch releases from GitHub API, providing a token may help.\nError: ${error}`
43+
)
44+
return
45+
}
46+
3747
const patterns = releasePatterns()
3848

3949
const coreRelease = release.assets.find(asset =>
@@ -52,7 +62,7 @@ const fetchReleases = async () => {
5262
const get = url => {
5363
return new Promise((resolve, reject) => {
5464
const request = https.get(url, {
55-
headers: { 'User-Agent': 'setup-dhall Github actoin' },
65+
headers: { 'User-Agent': 'setup-dhall Github action' },
5666
})
5767

5868
request.on('response', res => {
@@ -63,7 +73,11 @@ const get = url => {
6373
})
6474

6575
res.on('end', () => {
66-
resolve(data)
76+
if (res.statusCode == 200) {
77+
resolve(data)
78+
} else {
79+
reject(data)
80+
}
6781
})
6882
})
6983

0 commit comments

Comments
 (0)