Merge pull request #50 from dgraph-io/martinmr/non-string-var

Reject non-string keys or values in variable map.

Author: Paul Korzhyk

pydgraph/txn.py

@@ -78,6 +78,9 @@ def _common_query(self, query, variables=None):
             for key, value in variables.items():
                 if util.is_string(key) and util.is_string(value):
                     req.vars[key] = value
+                else:
+                    raise Exception(
+                        'Values and keys in variable map must be strings')
 
         return req
 

tests/test_txn.py

@@ -413,6 +413,25 @@ def test_read_index_key_same_txn(self):
         self.assertEqual([], json.loads(resp.json).get('me'),
                          "Expected 0 nodes read from index")
 
+    def test_non_string_variable(self):
+        """Tests sending a variable map with non-string values or keys results
+        in an Exception."""
+        helper.drop_all(self.client)
+        helper.set_schema(self.client, 'name: string @index(exact) .')
+
+        txn = self.client.txn()
+        query = """
+            query node($a: string) {
+                node(func: eq(name, $a))
+                {
+                    expand(_all_)
+                }
+            }
+        """
+        variables = {"$a": 1234}
+        with self.assertRaises(Exception):
+            _ = txn.query(query, variables=variables)
+
 
 class TestSPStar(helper.ClientIntegrationTestCase):
     def setUp(self):
@@ -503,7 +522,7 @@ def test_sp_star2(self):
             'uid': uid1,
             'friend': [{'name': 'Jan2', 'uid': uid2}]
         }], json.loads(resp.json).get('me'))
-        
+
         deleted2 = txn.mutate(del_obj={'uid': uid1, 'friend': None})
         self.assertEqual(0, len(deleted2.uids))
         resp = txn.query(query)