Skip to content

Commit e536138

Browse files
add cfg feature
1 parent 37735b9 commit e536138

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

ic-agent/src/agent/agent_test.rs

+4-2
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@ use futures_util::FutureExt;
1414
use ic_certification::{Delegation, Label};
1515
use ic_transport_types::{NodeSignature, QueryResponse, RejectCode, RejectResponse, ReplyResponse};
1616
use reqwest::Client;
17+
use std::sync::Arc;
1718
use std::{collections::BTreeMap, time::Duration};
18-
use std::{collections::VecDeque, sync::Arc};
1919
#[cfg(all(target_family = "wasm", feature = "wasm-bindgen"))]
2020
use wasm_bindgen_test::wasm_bindgen_test;
2121

@@ -36,7 +36,6 @@ fn make_agent_with_route_provider(
3636
tcp_retries: usize,
3737
) -> Agent {
3838
let client = Client::builder()
39-
.use_rustls_tls()
4039
.build()
4140
.expect("Could not create HTTP client.");
4241
Agent::builder()
@@ -50,6 +49,7 @@ fn make_agent_with_route_provider(
5049
.unwrap()
5150
}
5251

52+
#[cfg(feature = "hyper")]
5353
fn make_agent_with_hyper_transport_route_provider(
5454
route_provider: Arc<dyn RouteProvider>,
5555
tcp_retries: usize,
@@ -61,6 +61,7 @@ fn make_agent_with_hyper_transport_route_provider(
6161
client::legacy::{connect::HttpConnector, Client as LegacyClient},
6262
rt::TokioExecutor,
6363
};
64+
use std::collections::VecDeque;
6465

6566
let connector = HttpsConnectorBuilder::new()
6667
.with_webpki_roots()
@@ -382,6 +383,7 @@ async fn reqwest_client_status_okay_when_request_retried() -> Result<(), AgentEr
382383
}
383384

384385
#[cfg_attr(not(target_family = "wasm"), tokio::test)]
386+
#[cfg(feature = "hyper")]
385387
async fn hyper_client_status_okay_when_request_retried() -> Result<(), AgentError> {
386388
let map = BTreeMap::new();
387389
let response = serde_cbor::Value::Map(map);

ic-agent/src/agent/http_transport/hyper_transport.rs

+3-3
Original file line numberDiff line numberDiff line change
@@ -174,7 +174,7 @@ where
174174
}
175175

176176
let create_request_with_generated_url = || -> Result<Request<_>, AgentError> {
177-
let url = self.route_provider.route()?.join(&endpoint)?;
177+
let url = self.route_provider.route()?.join(endpoint)?;
178178
println!("{url}");
179179
let http_request = Request::builder()
180180
.method(&method)
@@ -305,8 +305,8 @@ where
305305

306306
fn status(&self) -> AgentFuture<Vec<u8>> {
307307
Box::pin(async move {
308-
let endpoint = &format!("status");
309-
self.request(Method::GET, endpoint, None).await
308+
let endpoint = "status".to_string();
309+
self.request(Method::GET, &endpoint, None).await
310310
})
311311
}
312312
}

0 commit comments

Comments
 (0)